Skip to content

Make IPASIR support compile #5549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2020
Merged

Conversation

tautschnig
Copy link
Collaborator

Hardness support was added to minisat2 only, and 89641a2 failed to
update the IPASIR interface.

Also cleanup the list of phony targets in the top-level Makefile, and
ensure that linking of the memory analyzer succeeds even in presence of
LIBS set on the make command line.

Fixes: #5345

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Hardness support was added to minisat2 only, and 89641a2 failed to
update the IPASIR interface.

Also cleanup the list of phony targets in the top-level Makefile, and
ensure that linking of the memory analyzer succeeds even in presence of
LIBS set on the make command line.

Fixes: diffblue#5345
@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #5549 (e5f4c93) into develop (bf62883) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5549   +/-   ##
========================================
  Coverage    68.52%   68.52%           
========================================
  Files         1187     1187           
  Lines        98265    98265           
========================================
  Hits         67339    67339           
  Misses       30926    30926           
Flag Coverage Δ
cproversmt2 42.96% <ø> (ø)
regression 65.68% <ø> (ø)
unit 32.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf62883...e5f4c93. Read the comment docs.

@tautschnig tautschnig merged commit 076b72e into diffblue:develop Nov 7, 2020
@tautschnig tautschnig deleted the fix-ipasir branch November 7, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot build with IPASIR - cryptominisat
4 participants