Add macOS installation instructions to README #5502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hannes-steffenhagen-diffblue
commented
Sep 22, 2020
hannes-steffenhagen-diffblue
commented
- Each commit message has a non-empty body, explaining why the change was made.
- Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- White-space or formatting changes outside the feature-related changed lines are in commits of their own.
hannes-steffenhagen-diffblue
requested review from
chrisr-diffblue,
kroening,
peterschrammel,
smowton and
tautschnig
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #5502 +/- ##
========================================
Coverage 68.34% 68.34%
========================================
Files 1186 1186
Lines 98081 98081
========================================
Hits 67035 67035
Misses 31046 31046
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
NlightNFotis
approved these changes
Sep 23, 2020
thomasspriggs
approved these changes
Sep 23, 2020
README.md
Outdated
| @@ -43,6 +43,19 @@ already have these, if not please download and run vcredist.x64.exe from | |||
| [Microsoft](https://support.microsoft.com/en-gb/help/2977003/the-latest-supported-visual-c-downloads) to install them prior to running | |||
| cbmc. | |||
|
|
|||
| ### macOS | |||
|
|
|||
| For macOS there is a [Homebrew](https://github.com/Homebrew/brew) package available. Once you have installed Homebrew, | |||
There was a problem hiding this comment.
I think the Homebrew link should be https://brew.sh rather than the github link. brew.sh is the "user" webpage, and importantly, says up-front how to install Homebrew :-)
It might also be worth linking the word 'available' to https://formulae.brew.sh/formula/cbmc ?
hannes-steffenhagen-diffblue
force-pushed
the
doc/homebrew-instructions
branch
from
28a17f8 to
6fcd7a8
Compare
chrisr-diffblue
approved these changes
Sep 23, 2020
peterschrammel
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.