Add github action to do CI checks against macOS #5439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannes-steffenhagen-diffblue
force-pushed
the
CI/macos-10.15-github-action
branch
from
6ddc0ab to
9a9d3af
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5439 +/- ##
========================================
Coverage 68.22% 68.22%
========================================
Files 1178 1178
Lines 97580 97580
========================================
Hits 66573 66573
Misses 31007 31007
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
hannes-steffenhagen-diffblue
force-pushed
the
CI/macos-10.15-github-action
branch
3 times, most recently
from
59da8e6 to
26ae068
Compare
hannes-steffenhagen-diffblue
requested review from
chrisr-diffblue,
kroening,
peterschrammel,
smowton and
tautschnig
as code owners
danpoe
approved these changes
Aug 5, 2020
| @@ -0,0 +1,35 @@ | |||
| # This is a basic workflow to help you get started with Actions | |||
There was a problem hiding this comment.
Looks like a comment from the template that could be removed 🥤
| pull_request: | ||
| branches: [ develop ] | ||
|
|
||
| # A workflow run is made up of one or more jobs that can run sequentially or in parallel |
| # we'll keep 5 times that around per OS | ||
| # to account for different versions/different | ||
| # flags | ||
| # Bump so CI runs again 2 |
There was a problem hiding this comment.
What does this comment mean? (line 19)
hannes-steffenhagen-diffblue
force-pushed
the
CI/macos-10.15-github-action
branch
from
953dbc1 to
354946b
Compare
NlightNFotis
approved these changes
Aug 6, 2020
chrisr-diffblue
approved these changes
Aug 6, 2020
| # we'll keep 5 times that around per OS | ||
| # to account for different versions/different | ||
| # flags | ||
| CCACHE_MAXSIZE: 500Mi |
There was a problem hiding this comment.
I guess as you backed out the ccache attempts, this is not needed any longer?
hannes-steffenhagen-diffblue
force-pushed
the
CI/macos-10.15-github-action
branch
from
354946b to
c2ad0e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says. We already do check macOS on Travis but we're in the process of converting all our CI to Github Actions to make things easier for all of us.
Currently doesn't cache builds because I couldn't get ccache to work, this can be added in a later PR (note that tests take a lot longer than builds anyway so the caching doesn't save us a ton of time).