Skip to content

Don't require -Wextra goto-gcc flag for warnings to be treated as errors #5393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

danpoe
Copy link
Contributor

@danpoe danpoe commented Jun 24, 2020

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The new version is not completely equivalent to how it would work in
gcc. In gcc, when both -Werror and -Wno-error are given (possibly
multiple times), the flag that was given last "wins". However we
currently don't have a way of knowing the order of options in cmdlinet.
@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #5393 into develop will decrease coverage by 0.84%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5393      +/-   ##
===========================================
- Coverage    68.19%   67.34%   -0.85%     
===========================================
  Files         1175     1175              
  Lines        97497    97496       -1     
===========================================
- Hits         66484    65658     -826     
- Misses       31013    31838     +825     
Flag Coverage Δ
#cproversmt2 ?
#regression 65.36% <ø> (-0.01%) ⬇️
#unit 32.24% <ø> (ø)
Impacted Files Coverage Δ
src/goto-cc/gcc_mode.cpp 67.52% <ø> (-0.10%) ⬇️
src/solvers/smt2/smt2irep.cpp 32.00% <0.00%> (-56.00%) ⬇️
src/solvers/smt2/smt2_conv.cpp 31.46% <0.00%> (-26.23%) ⬇️
src/solvers/floatbv/float_bv.cpp 55.25% <0.00%> (-18.88%) ⬇️
src/solvers/smt2/smt2_dec.cpp 61.53% <0.00%> (-16.93%) ⬇️
src/solvers/smt2/smt2_tokenizer.cpp 69.02% <0.00%> (-16.82%) ⬇️
src/solvers/flattening/pointer_logic.cpp 81.81% <0.00%> (-10.61%) ⬇️
src/solvers/smt2/smt2_parser.cpp 58.91% <0.00%> (-8.07%) ⬇️
src/util/expr_util.cpp 80.50% <0.00%> (-4.24%) ⬇️
src/solvers/smt2/smt2_format.cpp 70.37% <0.00%> (-3.71%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 823782c...188a69f. Read the comment docs.

@danpoe danpoe merged commit 7405bfb into diffblue:develop Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants