Skip to content

Fix typo in trace validation script #5315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

thk123
Copy link
Contributor

@thk123 thk123 commented Apr 22, 2020

The only useful work from this branch is fixing one typo - but hey, might as well.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • [na] The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • [na] Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • [na] My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@thk123
Copy link
Contributor Author

thk123 commented Apr 23, 2020

Looks like the two failing jobs that need to turn this off are:

  • (cbmc-linux-cmake-gcc)
  • (cbmc-windows)

I realise now that it is going to be hard to disable the tests for make which makes me sad - so probably the make ones will have to spuriously pass, but make the cmake one at least be safe (and use -E to exclude the xsd tests)

@thk123
Copy link
Contributor Author

thk123 commented Apr 24, 2020

cbmc-linux-cmake-gcc: missing xml-line:

xmllint not found, trace schema tests will fail 

cbmc-windows:

python3 not found: traces not validated against XSD 

Last failure (cbmc-windows-cmake) looks spurious so have hit retry

@codecov-io
Copy link

Codecov Report

Merging #5315 into develop will decrease coverage by 36.18%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #5315       +/-   ##
============================================
- Coverage    67.95%   31.76%   -36.19%     
============================================
  Files         1170      918      -252     
  Lines        96362    80168    -16194     
============================================
- Hits         65478    25465    -40013     
- Misses       30884    54703    +23819     
Flag Coverage Δ
#cproversmt2 ?
#regression ?
#unit 31.76% <ø> (ø)
Impacted Files Coverage Δ
src/cpp/cpp_id.h 0.00% <0.00%> (-100.00%) ⬇️
src/cpp/cpp_scope.h 0.00% <0.00%> (-100.00%) ⬇️
src/cpp/cpp_token.h 0.00% <0.00%> (-100.00%) ⬇️
src/cpp/cpp_name.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/cpp/cpp_util.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/util/identifier.h 0.00% <0.00%> (-100.00%) ⬇️
src/xmllang/graphml.h 0.00% <0.00%> (-100.00%) ⬇️
src/cpp/cpp_is_pod.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/cpp/template_map.h 0.00% <0.00%> (-100.00%) ⬇️
src/ansi-c/designator.h 0.00% <0.00%> (-100.00%) ⬇️
... and 893 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c1f7bb...774cd38. Read the comment docs.

@thk123 thk123 force-pushed the adjustments-to-validator branch from 774cd38 to 5b3640a Compare May 6, 2020 13:54
@thk123 thk123 marked this pull request as ready for review May 6, 2020 13:55
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR should have a less scary name.

@thk123 thk123 changed the title Adjustments to validator Fix typo in trace validation script Jun 11, 2020
@thk123 thk123 merged commit 91a2257 into diffblue:develop Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants