Change class loading and parsing warnings to debug messages. #5224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeannielynnmoulton
requested review from
cesaro,
cristina-david,
peterschrammel,
pkesseli,
smowton and
thk123
as code owners
allredj
approved these changes
Feb 5, 2020
| @@ -302,7 +302,7 @@ void java_bytecode_convert_classt::convert( | |||
| } | |||
| catch(const unsupported_java_class_signature_exceptiont &e) | |||
| { | |||
| warning() << "Class: " << c.name | |||
| debug() << "Class: " << c.name | |||
There was a problem hiding this comment.
What's the verbosity level for debug?
There was a problem hiding this comment.
it's like this
1 - error
2 - warning
4 - result
6 - status
8 - stats
10 - debug
majakusber
approved these changes
Feb 5, 2020
thk123
approved these changes
Feb 5, 2020
jeannielynnmoulton
force-pushed
the
jeannie/jbmcverbosity
branch
from
1f85eb2 to
979fb9d
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5224 +/- ##
========================================
Coverage 67.37% 67.37%
========================================
Files 1157 1157
Lines 95087 95087
========================================
Hits 64068 64068
Misses 31019 31019
Continue to review full report at Codecov.
|
Often, there are so many of these warnings that they lose all meaning as warning, so they are now moved to debug.
jeannielynnmoulton
force-pushed
the
jeannie/jbmcverbosity
branch
from
979fb9d to
12108aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often, there are so many of these warnings that they lose all meaning as
warning, so they are now moved to debug.