Document byte_update_exprt and rename non-const functions #4675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainbrenguier
requested review from
chrisr-diffblue,
kroening,
peterschrammel,
pkesseli,
smowton and
tautschnig
as code owners
tautschnig
requested changes
May 20, 2019
romainbrenguier
force-pushed
the
refactor/byte_update_exprt
branch
3 times, most recently
from
ce2a97a to
6fe7c1e
Compare
I've now kept both versions and deprecated the old one. |
tautschnig
approved these changes
May 22, 2019
src/util/simplify_expr.cpp
Outdated
| @@ -2057,20 +2057,22 @@ bool simplify_exprt::simplify_byte_extract(byte_extract_exprt &expr) | |||
|
|
|||
| bool simplify_exprt::simplify_byte_update(byte_update_exprt &expr) | |||
| { | |||
| const byte_update_exprt &expr_const = as_const(expr); | |||
There was a problem hiding this comment.
Is this use of as_const actually necessary?
Documentation was missing
The documentation was missing.
In some cases the non-const version was unnecessarily called because it has the same name as the const version. We define accessor functions with a different name to make the non-constantness explicit.
The non-const accessors which have the same name as the const one shouldn't be used anymore to avoid confusion and unknowningly calling the non-const version.
romainbrenguier
force-pushed
the
refactor/byte_update_exprt
branch
from
6fe7c1e to
15e9d8c
Compare
The non-const version shouldn't be used anymore when we don't actually need to modify the operands.
romainbrenguier
force-pushed
the
refactor/byte_update_exprt
branch
from
15e9d8c to
635ad8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases the non-const version was unnecessarily called because it
has the same name as the const version.
This pull requests avoids that from happening in 9 cases for op, 2 for value and 3 for
offset.