Skip to content

Factor out solver resource limits capability #4449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

peterschrammel
Copy link
Member

That need not be a part of prop_convt.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

That need not be a part of prop_convt.
Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that this works as described. However, while we are on the subject, please can we add a reproducible resource limit? We should only be using time limits as an absolute last resort option, to the point I am almost tempted to say this interface should be deprecated! (For people who haven't come across this problem before -- it is really important that CPROVER is deterministic, a whole bunch of things become really nasty if it is not.) The SMT-LIB standard has had reproducible resource limits for many years and it would not be hard to implement in our back-end. While we are working on this bit of code, please can we do something about this?

@peterschrammel
Copy link
Member Author

@martin-cs, happy to discuss this separately from this PR. I'll ping you.

@peterschrammel peterschrammel merged commit f45c69c into diffblue:develop Mar 28, 2019
@peterschrammel peterschrammel deleted the solver-resource-limits branch March 28, 2019 12:51
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️
This PR failed Diffblue compatibility checks (cbmc commit: 4896d61).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/106156861
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants