Skip to content

move letification into separate class #4396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

move letification into separate class #4396

wants to merge 1 commit into from

Conversation

kroening
Copy link
Member

The letification algorithm is the most complex aspect of the conversion to
SMT2, and is relatively independent of the rest. It may eventually have
uses elsewhere.

This is a clean move; any temptation to do improvements at the same time has been quenched, and will follow with later PRs.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • n/a My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The letification algorithm is the most complex aspect of the conversion to
SMT2, and is relatively independent of the rest.  It may eventually have
uses elsewhere.
Copy link
Contributor

@romainbrenguier romainbrenguier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class could do with a bit more documentation. But since the PR is just moving the code from smt2_conv to a new class I think it's fine.

@kroening kroening closed this Mar 18, 2019
@kroening kroening deleted the letify branch March 20, 2019 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants