Regularise the style and division of responsibilities in symex dispatch #4309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
requested review from
kroening,
peterschrammel and
tautschnig
as code owners
owen-mc-diffblue
approved these changes
Mar 1, 2019
tautschnig
approved these changes
Mar 1, 2019
src/goto-symex/symex_goto.cpp
Outdated
| state); | ||
| vcc( | ||
| negated_cond, | ||
| "unwinding assertion loop "+std::to_string(loop_number), |
There was a problem hiding this comment.
I guess clang-format doesn't like this?
Specifically: symex_step always dispatches without running either clean_expr or renaming, symex_step always takes care of the if-unreachable case (usually means skip instruction, but end-of-function has work to do regardless), symex_step takes care of advancing to the successor instruction after a simple instruction executes. No behavioural changes intended here except avoiding a little bit of redundant renaming / simplification when functions other than symex_step call symex_assume or vcc.
smowton
force-pushed
the
smowton/cleanup/regularise-symex-dispatch
branch
from
be89cf4 to
cca1dca
Compare
|
Fixed |
allredj
reviewed
Mar 1, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: cca1dca).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/102856060
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically: symex_step always dispatches without running either clean_expr or renaming, symex_step
always takes care of the if-unreachable case (usually means skip instruction, but end-of-function has
work to do regardless), symex_step takes care of advancing to the successor instruction after a simple
instruction executes.
No behavioural changes intended here except avoiding a little bit of redundant renaming / simplification
when functions other than symex_step call symex_assume or vcc.