remove two unused includes from util/mp_arith.h #4236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
requested review from
peterschrammel,
pkesseli,
smowton and
tautschnig
as code owners
tautschnig
approved these changes
Feb 20, 2019
src/util/mp_arith.h
Outdated
| @@ -11,11 +11,8 @@ Author: Daniel Kroening, kroening@kroening.com | |||
| #define CPROVER_UTIL_MP_ARITH_H | |||
|
|
|||
| #include <string> | |||
| #include <iosfwd> | |||
There was a problem hiding this comment.
But there is use of std::ostream? Presumably some other header currently drags this in, but removing this include won't be beneficial?
There was a problem hiding this comment.
Failing CI suggests that it might not actually get dragged in elsewhere...
kroening
force-pushed
the
mp_arith_includes
branch
2 times, most recently
from
e5e88b4 to
f916d31
Compare
kroening
requested review from
cesaro,
cristina-david,
NathanJPhillips and
thk123
as code owners
util/mp_arith.h is widely used, so this improves compile times.
kroening
force-pushed
the
mp_arith_includes
branch
from
f916d31 to
199df5f
Compare
kroening
changed the title
tautschnig
reviewed
Feb 21, 2019
| @@ -10,12 +10,13 @@ Author: Daniel Kroening, kroening@kroening.com | |||
| #ifndef CPROVER_UTIL_ARITH_TOOLS_H | |||
| #define CPROVER_UTIL_ARITH_TOOLS_H | |||
|
|
|||
| #include "deprecate.h" | |||
There was a problem hiding this comment.
We could actually get rid of this include by removing to_unsigned_integer, which isn't used.
3 tasks
smowton
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
util/mp_arith.h is widely used, so this improves compile times.