Skip to content

Fix typo in definition of unsigned __int128 #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 104 additions & 0 deletions regression/cbmc/unsigned___int128/main.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,104 @@
# include <stdint.h>

typedef unsigned __int128 uint128_t;

typedef uint64_t limb;
typedef uint128_t widelimb;

typedef limb felem[4];
typedef widelimb widefelem[7];

felem p = {0x1FFFFFFFFFFFFFF,
0xFFFFFFFFFFFFFF,
0xFFFFE000000000,
0x00000000000002};


/*-
* Reduce seven 128-bit coefficients to four 64-bit coefficients.
* Requires in[i] < 2^126,
* ensures out[0] < 2^56, out[1] < 2^56, out[2] < 2^56, out[3] <= 2^56 + 2^16 */
void reduce(felem out, const widefelem in)
{

__CPROVER_assume(in[0]<(widelimb)((widelimb)1<<126));
__CPROVER_assume(in[1]<((widelimb)1<<126));
__CPROVER_assume(in[2]<((widelimb)1<<126));
__CPROVER_assume(in[3]<((widelimb)1<<126));

static const widelimb two127p15 = (((widelimb) 1) << 127) +
(((widelimb) 1) << 15);
static const widelimb two127m71 = (((widelimb) 1) << 127) -
(((widelimb) 1) << 71);
static const widelimb two127m71m55 = (((widelimb) 1) << 127) -
(((widelimb) 1) << 71) - (((widelimb) 1) << 55);
widelimb output[5];

/* Add 0 mod 2^224-2^96+1 to ensure all differences are positive */
output[0] = in[0] + two127p15;
output[1] = in[1] + two127m71m55;
output[2] = in[2] + two127m71;
output[3] = in[3];
output[4] = in[4];

/* Eliminate in[4], in[5], in[6] */
output[4] += in[6] >> 16;
output[3] += (in[6] & 0xffff) << 40;
output[2] -= in[6];

output[3] += in[5] >> 16;
output[2] += (in[5] & 0xffff) << 40;
output[1] -= in[5];

output[2] += output[4] >> 16;
output[1] += (output[4] & 0xffff) << 40;
output[0] -= output[4];

/* Carry 2 -> 3 -> 4 */
output[3] += output[2] >> 56;
output[2] &= 0x00ffffffffffffff;

output[4] = output[3] >> 56;
output[3] &= 0x00ffffffffffffff;

/* Now output[2] < 2^56, output[3] < 2^56, output[4] < 2^72 */

/* Eliminate output[4] */
output[2] += output[4] >> 16;
/* output[2] < 2^56 + 2^56 = 2^57 */
output[1] += (output[4] & 0xffff) << 40;
output[0] -= output[4];

/* Carry 0 -> 1 -> 2 -> 3 */
output[1] += output[0] >> 56;
out[0] = output[0] & 0x00ffffffffffffff;

output[2] += output[1] >> 56;
/* output[2] < 2^57 + 2^72 */

assert(output[2] < (((widelimb)1)<<57)+(((widelimb)1)<<72));

out[1] = output[1] & 0x00ffffffffffffff;
output[3] += output[2] >> 56;
/* output[3] <= 2^56 + 2^16 */
assert(output[3] < (((widelimb)1)<<56)+(((widelimb)1)<<16));

out[2] = output[2] & 0x00ffffffffffffff;

/*-
* out[0] < 2^56, out[1] < 2^56, out[2] < 2^56,
* out[3] <= 2^56 + 2^16 (due to final carry),
* so out < 2*p
* p[0],p[1],p[2],p[3]
* p = p[0] + 2**56 * p[1] ...
*
* out[3] < p[3] ||
* out[3] == p[3] && (
*
*/
out[3] = output[3];
assert(out[3] < p[0] ||
(out[3] == p[0] && (
out[2] < p[1] || (out[2]==p[1] && (out[1]<p[2] || out[1]==p[2]
&& (out[0]<p[3]))))));
}
8 changes: 8 additions & 0 deletions regression/cbmc/unsigned___int128/test.desc
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
CORE
main.c
--unsigned-overflow-check --signed-overflow-check --function reduce
^EXIT=0$
^SIGNAL=0$
^VERIFICATION SUCCESSFUL$
--
^warning: ignoring
2 changes: 1 addition & 1 deletion src/ansi-c/c_types.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -636,7 +636,7 @@ Function: gcc_unsigned_int128_type

typet gcc_unsigned_int128_type()
{
typet result=signedbv_typet(128);
typet result=unsignedbv_typet(128);
result.set(ID_C_c_type, ID_unsigned_int128);
return result;
}
Expand Down