Split parse_list_types into two functions

[JohnDumbell]

In some situations you might want to know what the bytecode type is and then manually perform some operation afterwards, in this case it's useful to have a method that returns the string representation of the bytecode type.

• Each commit message has a non-empty body, explaining why the change was made.
• Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
• Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
• My commit message includes data points confirming performance improvements (if claimed).
• My PR is restricted to a single feature or bugfix.
• White-space or formatting changes outside the feature-related changed lines are in commits of their own.

[thk123]

It'd be a great time to add a unit test for these methods

[thk123]

⛏️

const std::vector<std::string> type_strings = parse_raw_list_types(src, opening_bracket, closing_bracket); 
std::vector<typet> type_list;
std::transform(
  type_strings.begin(), 
  type_strings.end(), 
  std::back_inserter(type_list), 
  [&](const std::string &raw_type) {
    const typet new_type = java_type_from_string(raw_type, class_name_prefix);
    INVARIANT(new_type != nil_typet(), "Failed to parse type");
    return new_type;
});
return type_list;

[JohnDumbell]

Does this actually give any real benefit when you're simply looping through an entire list with no bells or whistles?

[thk123]

That's exactly when you should use it, so the reader can tell that you are looping through an entire list with no bells and whistles! It wouldn't work if you had some whistles.

FYI the ⛏️ here means a non-blocking comment that you could fix if you're in the area but mostly there as something to try and do in future.

[JohnDumbell]

Cheers, was mostly just curious about the recommendation (wasn't meant as a refutal).

[allredj]

🚫
This PR failed Diffblue compatibility checks (cbmc commit: ccd22e8).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/90702246
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

• the cbmc commit has disappeared in the mean time (e.g. in a force-push)
• the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

[thk123]

Joel bot is feeling a bit sensitive at the moment as previously merged CBMC PRs have broken TG - since this touches Java code can you wait until it comes back online? (hopefully shortly).

[tautschnig]

Please rebase to re-trigger the TG check.

[allredj]

✔️
Passed Diffblue compatibility checks (cbmc commit: 4898928).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/90880596