Skip to content

Remove unused includes from regression tests #3203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2018

Conversation

tautschnig
Copy link
Collaborator

This cleanup avoids giving the false impression we would be testing any
functions declared in those header files.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@martin-cs
Copy link
Collaborator

Am curious to know how you found these (if automated; is this all of them?) but possibly even more curious to know why this causes failures in the unit tests...

@tautschnig tautschnig self-assigned this Oct 20, 2018
@tautschnig tautschnig force-pushed the regression-test-header-cleanup branch 2 times, most recently from ebe8e70 to 90306cf Compare October 29, 2018 19:17
This cleanup avoids giving the false impression we would be testing any
functions declared in those header files, which in turn simplifies moving tests
that exercise the internal modelling library to a separate folder.
clang-format was complaining about lines I hadn't touched, cleaning them up
anyhow.
@tautschnig tautschnig force-pushed the regression-test-header-cleanup branch from 90306cf to 10409de Compare October 29, 2018 20:52
@tautschnig
Copy link
Collaborator Author

@martin-cs This is now fixed: one of the includes provided NULL...

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: 10409de).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/89574972
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

@kroening kroening merged commit b473cfc into diffblue:develop Oct 30, 2018
@tautschnig tautschnig deleted the regression-test-header-cleanup branch October 30, 2018 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants