Add a virtual destructor to cprover_exception_baset #3137
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While exceptions under normal usage scenarios don't need a virtual destructor
(when an exception is thrown, it is the runtimes responsibility to properly
destroy it, and it does know the type of the exception at the point where it's
thrown), it is just generally good practice to have virtual destructors in base
classes to accomodate for situations where a polymorphic destruction may be
needed.
This also adds an explanation for why we use this class in the first place instead of just deriving from
std::exception