Skip to content

Add cmdlinet::has_option #3083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

smowton
Copy link
Contributor

@smowton smowton commented Oct 2, 2018

Previously cmdlinet could parse a whole command-line, but it wasn't possible to verify before using cmdlinet::set that an option was valid. This is useful when a driver program receives options in a format other than a string (e.g. a structured list) and wishes to check that the options would have been valid if supplied conventionally, rather than silently drop invalid args.

  • Each commit message has a non-empty body, explaining why the change was made.
  • My contribution is formatted in line with CODING_STANDARD.md.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This allows a user to check that a particular option is accepted, which allows validation
when not using the full `parse` routine.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: 3f56a37).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/86632089

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: 1225b77).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/86633726

@kroening kroening merged commit ebf5ce8 into diffblue:develop Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants