-
Notifications
You must be signed in to change notification settings - Fork 277
Remove unused type temp_working_dirt #3054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused type temp_working_dirt #3054
Conversation
8264abf
to
77afd48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit picks: 1) in the commit message: s/functionally/functionality/ and 2) remove the blank line at the end of tempdir.cpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR failed Diffblue compatibility checks (cbmc commit: 8264abf).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/86163537
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed Diffblue compatibility checks (cbmc commit: 77afd48).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/86164156
77afd48
to
b48381d
Compare
@tautschnig Fixed the type and removed the extra line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed Diffblue compatibility checks (cbmc commit: b48381d).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/86170412
AWS fails due to seemingly unrelated timeout error. I've restarted the build. |
I did retry the CodeBuild thing and it passed, but it didn't update the status in here. Not sure what's going on with that. |
Maybe we can merge some other PR so that you can rebase this one ;-) |
@hannes-steffenhagen-diffblue You can now do a rebase. |
This type has been added in 2012 and is presently unused. In its present state it is difficult to use as it doesn't permit any way to recover from potential errors (it is instead asserted that no errors can happen, which is not true). Should functionality like this be needed in the future, I'd recommend a wrapper function like ``` template<typename Closure> void run_with_different_working_dir( const std::string& working_dir, Closure closure); ``` Which would change the working directory, execute the closure and change the working directory back afterwards, throwing a system_exceptiont on failure.
b48381d
to
e2fc031
Compare
@tautschnig done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed Diffblue compatibility checks (cbmc commit: e2fc031).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/86268564
This type has been added in 2012 and is presently unused. In its present state
it is difficult to use as it doesn't permit any way to recover from potential
errors (it is instead asserted that no errors can happen, which is not true).
Should functionally like this be needed in the future, I'd recommend a wrapper
function like
Which would change the working directory, execute the closure and change the
working directory back afterwards, throwing a system_exceptiont on failure.