object_size can now do objects with dynamic size #2852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
dynamic_object_size
branch
from
30aa417 to
0149e41
Compare
kroening
requested review from
chrisr-diffblue,
smowton and
thk123
as code owners
kroening
force-pushed
the
dynamic_object_size
branch
3 times, most recently
from
407eb86 to
0149e41
Compare
tautschnig
approved these changes
Aug 29, 2018
| if(to_integer(size_expr, object_size)) | ||
| continue; | ||
| object_size = | ||
| typecast_exprt::conditional_cast(size_expr, postponed.expr.type()); |
There was a problem hiding this comment.
Could the code around here be refactored so that it is trivial that object_size will always be initialised when used below? I'd suggest:
if(expr.id() != ID_symbol)
continue;
const size_expr = size_of_expr(type, ns);
if(size_expr.is_nil())
continue;
const exprt object_size =
typecast_exprt::conditional_cast(size_expr, postponed.expr.type());
kroening
force-pushed
the
dynamic_object_size
branch
from
0149e41 to
763d005
Compare
tautschnig
reviewed
Aug 29, 2018
| @@ -786,24 +786,19 @@ void bv_pointerst::do_postponed( | |||
| { | |||
| const exprt &expr=*it; | |||
|
|
|||
| mp_integer object_size; | |||
| exprt object_size; | |||
There was a problem hiding this comment.
This is no longer needed.
kroening
force-pushed
the
dynamic_object_size
branch
2 times, most recently
from
05c7f6e to
86f4394
Compare
kroening
force-pushed
the
dynamic_object_size
branch
from
86f4394 to
5641ebc
Compare
kroening
force-pushed
the
dynamic_object_size
branch
from
5641ebc to
11431ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.