Skip to content

Remove destination directory before trying to move to it in AppVeyor #1846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2018
Merged

Remove destination directory before trying to move to it in AppVeyor #1846

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ install:
Move-Item win_bison.exe bin\bison.exe -force
Move-Item win_flex.exe bin\flex.exe -force
Move-Item FlexLexer.h include\FlexLexer.h -force
Remove-Item bin\data -Force -Recurse -ErrorAction SilentlyContinue
Move-Item data bin\data -force
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the -force then no longer necessary here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure actually. The docs seem to indicate that -Force suppresses user confirmation, but that's also what -Confirm seems to be for.

In my testing I've not actually seen much of a difference between Move-Item and Move-Item -Force, although that might just be a property of the environment there.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the info. So I'd remove the -force and wait for it to break, but I'll let the code owners make the call here.

bison -V
flex -V
Expand Down