Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: diffblue/cbmc
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 84cf0a5
Choose a base ref
...
head repository: diffblue/cbmc
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6e1615c
Choose a head ref
  • 6 commits
  • 80 files changed
  • 1 contributor

Commits on Nov 14, 2023

  1. Remove util_make_unique 

    With the move to C++ 17 we can use std::make_unique instead.
    @tautschnig
    tautschnig committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    56046a5 View commit details
    Browse the repository at this point in the history

  2. Remove local declaration of void_t 

    With the move to C++ 17 we can use std::void_t instead.
    @tautschnig
    tautschnig committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    2d62871 View commit details
    Browse the repository at this point in the history

  3. Replace file_util.{h,cpp} by std::filesystem 

    With C++ 17 we can use the STL-provided implementation instead of
rolling our own (platform-dependent) code.
    @tautschnig
    tautschnig committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    0c33e41 View commit details
    Browse the repository at this point in the history

  4. Fix invalid-escape-sequence warning 

    Python warns about the use of `\d`: we should use raw strings here as
that's not meant to be an escape sequence.
    @tautschnig
    tautschnig committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    130fd65 View commit details
    Browse the repository at this point in the history

  5. Fix libstdc++-not-found error 

    See
https://github.com/diffblue/cbmc/actions/runs/6856483568/job/18643716705?pr=6749
for one example of the failure: cargo-induced clang runs (via the cc
crate) weren't finding the C++ library (which ought to be libc++ and not
libstdc++ on this MacOS target). This appears to be caused by the
minimum build target being too low (where the cc crate is the one
setting that minimum). Override that by setting an environment variable.
See
https://github.com/rust-lang/cc-rs/blob/2d6a3b2119cf5eacc01e1f2877e064a7aede7819/src/lib.rs#L3497C52-L3497C76
for the Rust code implementing the logic.
    @tautschnig
    tautschnig committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    7320b81 View commit details
    Browse the repository at this point in the history

  6. Fix ccache configuration of check-macos-12-cmake-clang-rust 

    The prefix lookup resulted in picking up the Release-Glucose cache from
check-macos-12-cmake-clang. This cache, however, was established with
Glucose as a SAT solver, which implies different compiler
command lines. Consequently, there would be 0 cache hits.
    @tautschnig
    tautschnig committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    6e1615c View commit details
    Browse the repository at this point in the history
Loading