Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace null-ls.nvim #138

Closed
dietrichm opened this issue Aug 13, 2023 · 2 comments
Closed

Replace null-ls.nvim #138

dietrichm opened this issue Aug 13, 2023 · 2 comments
Labels
nvim Neovim specifics and bleeding edge features task

Comments

@dietrichm
Copy link
Owner

This plugin is no longer maintained: jose-elias-alvarez/null-ls.nvim#1621

@dietrichm dietrichm added task nvim Neovim specifics and bleeding edge features labels Aug 13, 2023
@Lamarcke
Copy link

I'm currently using nvim-lint and formatter.nvim to achieve the same result.
My formatter.nvim config:

return {
    "mhartington/formatter.nvim",
    config = function()
        local formatter = require("formatter")
        local default_formatters = require("formatter.defaults")
        local prettierd = default_formatters.prettierd
        local stylua = default_formatters.stylua
        formatter.setup({
            filetype = {
                javascript = {
                    prettierd
                },
                javascriptreact = {
                    prettierd
                },
                typescript = {
                    prettierd
                },
                typescriptreact = {
                    prettierd
                },
                lua = {
                    stylua
                }
            }

        })
    end
}

My nvim-lint config:

return {
    "mfussenegger/nvim-lint",
    config = function()
        local lint = require("lint")
        lint.linters_by_ft = {
            javascript = {
                "eslint_d"
            },
            typescript = {
                "eslint_d"
            },
            javascriptreact = {
                "eslint_d"
            },
            typescriptreact = {
                "eslint_d"
            }
        }
    end

}

Both plugins are standalone, so no dependency on external binaries like the efm language server.

@dietrichm
Copy link
Owner Author

Thanks!

dietrichm added a commit that referenced this issue Sep 3, 2023
dietrichm added a commit that referenced this issue Sep 3, 2023
andreaswachowski added a commit to andreaswachowski/dotfiles that referenced this issue Sep 27, 2023
Basic setup from [^1]. Basic bundle integration found in [^3].

Open issues:
- Linting fails when rubocop is not available in the bundle.
  One can provide a function for the linter[^2] and should be able to
  use either the bundled rubocop, or a global rubocop as fallback.
- When rubocop itself fails (with error code 2), like when it sees an
  unrecognized cop in .rubocop.yml, this is unnoticed during editing.
- Make rubocop run on BufReadPost, InsertLeave, and TextChanged events.
  This is mentioned in mfussenegger/nvim-lint#336

[^1]: dietrichm/dotfiles#138
[^2]: mfussenegger/nvim-lint#18
[^3]: https://github.com/pfeiferj/dotfiles/blob/9fe44801e52590610d2090f2c03df6fbb31b6f57/dot_config/nvim/lua/plugins/lint.lua
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nvim Neovim specifics and bleeding edge features task
Projects
None yet
Development

No branches or pull requests

2 participants