forked from laravel/framework
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix QueueWorkTest cases asserting nothing (laravel#32958)
Setting up PHPUnit's $this->expectException(), calls to $worker->daemon() throw that exception so the test case immediately stops there. Subsquent assertions are being skipped. Fixing this shows testJobRunsIfAppIsNotInMaintenanceMode actually never runs any jobs on the queue. When running the whole laravael/framework test suite, Worker::memoryExceeded() can also return true from previous test cases being run. So both of these tests may skip running the queue, instead silently calling exit(12) for no more memory.
- Loading branch information
Showing
1 changed file
with
24 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters