Using page->text() as fallback meta #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is something I mentioned in Issue diesdasdigital#14, and I ended up adding these changes to my own site. I'm putting it in as a PR just in case you think it would help you as well. So basically, what this does in a nutshell is add an excerpt of page->text() as a fallback between manually enterered meta info and the sitewide meta info. So, for example, OpenGraph looks like... 1. OpenGraph Description 2. Meta Description 3. Excerpt of Page Text 4. Sitewide Meta Description 5. blank/error message If this is unhelpful or not what you were thinking for this plugin, do please ignore. Just providing what I did in case it helps others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something I mentioned in Issue #14, and I ended up adding these changes to my own site. I'm putting it in as a PR just in case you think it would help you as well.
So basically, what this does in a nutshell is add an excerpt of
page->text()->excerpt(180)as a fallback between manually enterered meta info and the sitewide meta info.So, for example, OpenGraph looks like...
If this is unhelpful or not what you were thinking for this plugin, do please ignore. Just providing what I did in case it helps others.