[move-lang] Remove ability to assign values to named addresses in source code

[tzakian]

This PR removes the ability to declare named address values in Move source code. Instead, all named address values need to be passed to the compiler -- today via the command line, but in the future this will be handled by the package system.

Nothing too interesting is happening in this PR, just a lot of plumbing. Probably the most interesting is that we now include the named address values in the metadata file that we have temporarily in the CLI.

Testing

Updated tests to make them all pass with the new syntax.

[tnowacki]

Mostly good to go! Just maybe an additional test showing the old address syntax is invalid. And the few other small comments around.

[tnowacki]

We can make improvements as we go, I'd like to see those move-prover arguments as lazy-static or something, so they aren't hard coded.
Thanks for doing this!

If you don't mind, can you also update the changelog?

[tnowacki]

Is there someway to populate these with the stuff in diem-framework and mvoe-stdlib, just worried about changes overtime

[tzakian]

Once we have packages we can do this without introducing a Cargo dep on the diem side of things. However, if I try to use the stuff from the diem-framework that will then introduce a diem dependency. So at least for now, I think we should probably keep this like this. I'll add a TODO and tag myself in it to change this once packages are in.

[tnowacki]

/land

[github-actions]

Cluster Test Result

Test runner setup time spent 248 secs
Compatibility test results for land_abdc8f0d ==> land_093bc9ed (PR)
1. All instances running land_abdc8f0d, generating some traffic on network
2. First full node land_abdc8f0d ==> land_093bc9ed, to validate new full node to old validator node traffic
3. First Validator node land_abdc8f0d ==> land_093bc9ed, to validate storage compatibility
4. First batch validators (14) land_abdc8f0d ==> land_093bc9ed, to test consensus and traffic between old full nodes and new validator node
5. First batch full nodes (14) land_abdc8f0d ==> land_093bc9ed
6. Second batch validators (15) land_abdc8f0d ==> land_093bc9ed, to upgrade rest of the validators
7. Second batch of full nodes (15) land_abdc8f0d ==> land_093bc9ed, to finish the network upgrade, time spent 676 secs
all up : 1063 TPS, 4275 ms latency, 4850 ms p99 latency, no expired txns, time spent 250 secs
Logs: http://kibana.ct-1-k8s-testnet.aws.hlw3truzy4ls.com/app/kibana#/discover?_g=(time:(from:'2021-08-09T20:28:22Z',to:'2021-08-09T20:53:09Z'))
Dashboard: http://grafana.ct-1-k8s-testnet.aws.hlw3truzy4ls.com/d/performance/performance?from=1628540902000&to=1628542389000
Validator 1 logs: http://kibana.ct-1-k8s-testnet.aws.hlw3truzy4ls.com/app/kibana#/discover?_g=(time:(from:'2021-08-09T20:28:22Z',to:'2021-08-09T20:53:09Z'))&_a=(columns:!(log),query:(language:kuery,query:'kubernetes.pod_name:"val-1"'),sort:!(!('@timestamp',desc)))

Repro cmd:

./scripts/cti --tag land_abdc8f0d --cluster-test-tag land_093bc9ed -E BATCH_SIZE=15 -E UPDATE_TO_TAG=land_093bc9ed --report report.json --suite land_blocking_compat

🎉 Land-blocking cluster test passed! 👌