fix error due to breaking change in http 0.13 #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dart-lang/http#538 The breaking change of the http makes all the request originally in string, now must be Uri. Using Uri.parse to refactor all the place using http package method
|
Thanks for the contribution! @SeasonLeee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you can see from below screenshot:
And further discussion on solution can be found here:
dart-lang/http#538
The breaking change of the http makes all the request originally in string, now must be Uri, if the user's Flutter is 2.0+
In this commit I was using Uri.parse to refactor all the place using http package method, changing the string to Uri.