Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve TypeScript error in PDFDownloadLink component react-pdf v4 #2888

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

islam-kamel
Copy link

@islam-kamel islam-kamel commented Sep 26, 2024

Fixed #2886

Changes Made:

  • Updated PDFDownloadLinkProps to correctly handle the 'children' prop, allowing for both ReactNode and function types.
  • Ensured compatibility with TypeScript type definitions to prevent type mismatches.
  • Added necessary type assertions to preserve functionality.

Copy link

changeset-bot bot commented Sep 26, 2024

⚠️ No Changeset found

Latest commit: 4a1bdcc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@islam-kamel islam-kamel changed the title fix: resolve #2886 TypeScript error in PDFDownloadLink component react-pdf v4 fix: resolve TypeScript error in PDFDownloadLink component react-pdf v4 Sep 26, 2024
@robbycarter
Copy link

Anything i can do to help speed up this PR?

@mamlzy
Copy link

mamlzy commented Oct 18, 2024

@diegomura sorry for tagging you

@fatihgnc
Copy link

fatihgnc commented Nov 7, 2024

I need this PR to be merged...

@fabianponten
Copy link

This is still an issue in V4.1.5, is there any fix or workaround for this?

@mamlzy
Copy link

mamlzy commented Nov 26, 2024

This is still an issue in V4.1.5, is there any fix or workaround for this?

yes i still facing this issue. still using @ts-expect-error to ignoring the type errors

@diegomura
Copy link
Owner

There's an open question in this PR I left on code

Copy link

@goldenaca goldenaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OKAY

@mouchegmouradian
Copy link

when will this be merged ?

@Maquinours
Copy link

Up.
It is a big issue for all typescript users.

@robbycarter
Copy link

I hope we get this resolved before the end of the year.

@mouchegmouradian
Copy link

mouchegmouradian commented Dec 17, 2024

@robbycarter @Maquinours

Until it's fixed you can do something like this:

Screenshot 2024-12-17 at 11 45 46

the @ts-expect-error is better than @ts-ignore because when this PR is merged and the error isn't there anymore the @ts-expect-error will throw an error itself saying there are no errors, then you can remove it from your code safely.

@Maquinours
Copy link

Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript Error in PDFDownloadLink with React-PDF v4
9 participants