feat: exclude rects on textkit layout container #1895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegomura
force-pushed
the
dm/textkit-exclude-rects
branch
from
3d117c2 to
2be6d6b
Compare
This was referenced Jun 20, 2022
carlobeltrame
added a commit
to carlobeltrame/react-pdf
that referenced
this pull request
Jul 5, 2022
Bug was introduced in diegomura#1895 Error message: TypeError: rect2 is undefined (or similar) In case there is no rect left for the text to flow to, we have to stay in the last one and overflow its bottom.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports passing an array of
excludedRectstotextkit.layoutTextfunction to support elements wrapping text via thefloatCSS property