Matrix and Xmas profiles #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5Q profiles
|
"indexes will need updating"? |
|
index.ts, adding to import etc |
enum removed during debug attempt, left out because we're just translating from num -> enum -> num unnecessarily. enable and disable transition were missing/handled differently to key-state
chris13524
previously requested changes
Dec 20, 2018
There was a problem hiding this comment.
See two cases of code changes that break the public interface other packages may (and do) depend on.
Overall, I suggest you utilize the topLeftCoordinates property to calculate the rows rather than hard coding the LED IDs.
multiplier changed from 170 to 25, inDelay changed from 1 to 0, results in faster yet still smooth animation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5Q profiles, indexes will need updating