➖ Remove DDTrace #1299

rblaine95 · 2025-01-28T07:13:36Z

We might not need to install it as we're using Auto Instrumentation to inject it in K8s

Did some testing, confirmed, we don't need to install DDTrace and can just use the Auto-Instrumentation.
Continuous Profiler and APM works.

* We might not need to install it as we're using Auto Instrumentation to inject it in K8s

github-actions · 2025-01-28T07:43:39Z

K8s Test Coverage

File	Stmts	Miss	Cover	Missing
app
main.py	78	2	97%	119–120
app/models
wallet.py	36	4	89%	100–105
app/routes
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	139	33	76%	88–90, 95, 152–154, 159, 231, 239–241, 246, 288–293, 299–301, 362–364, 369, 406–408, 413, 449–451, 505–507
app/routes/wallet
credentials.py	80	53	34%	57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
acapy_ledger.py	61	12	80%	110–111, 124–140, 196–197
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	166	35	79%	118–160, 201–205, 360–364, 403–408, 441–445, 473–478, 527–528
app/services/issuer
acapy_issuer_v2.py	101	12	88%	63, 97–106, 110, 126–127, 174, 228–229, 256
app/services/onboarding
tenants.py	63	49	22%	30–103, 113–143
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	95	5	95%	100–102, 276–281
set_endorser_metadata.py	72	40	44%	32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/util
acapy_verifier_utils.py	123	5	96%	81–84, 164–168, 245
assert_public_did.py	18	8	56%	17–33
credentials.py	14	2	86%	13, 18
retry_method.py	36	15	58%	20–35, 76–77, 91–103
save_exchange_record.py	13	1	92%	29
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	2	86%	34–35
shared
log_config.py	53	20	62%	41–94, 103–110, 152, 161–173
shared/models
connection_record.py	24	1	96%	47
credential_exchange.py	43	7	84%	85–88, 101–104
endorsement.py	85	68	20%	36–70, 92–122, 132–179
presentation_exchange.py	40	9	78%	54–56, 62–64, 82, 87, 91
protocol.py	10	1	90%	18
trustregistry.py	63	7	89%	22, 44, 75–83
shared/services
nats_jetstream.py	36	4	89%	56, 60, 64, 68
shared/util
api_router.py	14	1	93%	17
mock_agent_controller.py	55	6	89%	23, 74–78
trustregistry
main.py	82	4	95%	46–48, 110
waypoint
main.py	48	1	98%	64
waypoint/services
nats_service.py	112	3	97%	73–75
TOTAL	4943	546	89%

Tests	Skipped	Failures	Errors	Time
896	6 💤	0 ❌	0 🔥	4m 45s ⏱️

github-actions · 2025-01-28T07:43:40Z

K8s Regression Test Coverage

File	Stmts	Miss	Cover	Missing
app
main.py	78	2	97%	119–120
app/models
wallet.py	36	4	89%	100–105
app/routes
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	139	33	76%	88–90, 95, 152–154, 159, 231, 239–241, 246, 288–293, 299–301, 362–364, 369, 406–408, 413, 449–451, 505–507
app/routes/wallet
credentials.py	80	53	34%	57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
acapy_ledger.py	61	19	69%	43–49, 79, 110–111, 124–140, 146–149, 196–197
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	166	46	72%	118–160, 201–205, 360–364, 403–408, 441–445, 463–478, 484–493, 527–528
app/services/issuer
acapy_issuer_v2.py	101	12	88%	63, 97–106, 110, 126–127, 174, 228–229, 256
app/services/onboarding
tenants.py	63	49	22%	30–103, 113–143
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	95	5	95%	100–102, 276–281
set_endorser_metadata.py	72	40	44%	32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/util
acapy_verifier_utils.py	123	5	96%	81–84, 164–168, 245
assert_public_did.py	18	12	33%	14–34
check_endorser_connection.py	10	4	60%	14–24
credentials.py	14	2	86%	13, 18
retry_method.py	36	30	17%	15–36, 68–114
save_exchange_record.py	13	1	92%	29
string.py	15	4	73%	15–16, 20, 24
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	7	50%	21–39
shared
log_config.py	53	20	62%	41–94, 103–110, 152, 161–173
shared/models
connection_record.py	24	1	96%	47
credential_exchange.py	43	7	84%	85–88, 101–104
endorsement.py	85	68	20%	36–70, 92–122, 132–179
presentation_exchange.py	40	9	78%	54–56, 62–64, 82, 87, 91
protocol.py	10	1	90%	18
trustregistry.py	63	7	89%	22, 44, 75–83
shared/services
nats_jetstream.py	36	4	89%	56, 60, 64, 68
shared/util
api_router.py	14	1	93%	17
mock_agent_controller.py	55	6	89%	23, 74–78
trustregistry
main.py	82	4	95%	46–48, 110
waypoint
main.py	48	1	98%	64
waypoint/services
nats_service.py	112	3	97%	73–75
TOTAL	4943	596	88%

Tests	Skipped	Failures	Errors	Time
896	48 💤	0 ❌	0 🔥	6m 25s ⏱️

github-actions · 2025-01-28T07:58:47Z

K8s Test Coverage

File	Stmts	Miss	Cover	Missing
app
main.py	78	2	97%	119–120
app/models
wallet.py	36	4	89%	100–105
app/routes
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	139	33	76%	88–90, 95, 152–154, 159, 231, 239–241, 246, 288–293, 299–301, 362–364, 369, 406–408, 413, 449–451, 505–507
app/routes/wallet
credentials.py	80	53	34%	57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
acapy_ledger.py	61	12	80%	110–111, 124–140, 196–197
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	166	35	79%	118–160, 201–205, 360–364, 403–408, 441–445, 473–478, 527–528
app/services/issuer
acapy_issuer_v2.py	101	12	88%	63, 97–106, 110, 126–127, 174, 228–229, 256
app/services/onboarding
tenants.py	63	49	22%	30–103, 113–143
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	95	5	95%	100–102, 276–281
set_endorser_metadata.py	72	40	44%	32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/util
acapy_verifier_utils.py	123	5	96%	81–84, 164–168, 245
assert_public_did.py	18	8	56%	17–33
credentials.py	14	2	86%	13, 18
retry_method.py	36	15	58%	20–35, 76–77, 91–103
save_exchange_record.py	13	1	92%	29
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	2	86%	34–35
shared
log_config.py	53	20	62%	41–94, 103–110, 152, 161–173
shared/models
connection_record.py	24	1	96%	47
credential_exchange.py	43	7	84%	85–88, 101–104
endorsement.py	85	68	20%	36–70, 92–122, 132–179
presentation_exchange.py	40	9	78%	54–56, 62–64, 82, 87, 91
protocol.py	10	1	90%	18
trustregistry.py	63	7	89%	22, 44, 75–83
shared/services
nats_jetstream.py	36	4	89%	56, 60, 64, 68
shared/util
api_router.py	14	1	93%	17
mock_agent_controller.py	55	6	89%	23, 74–78
trustregistry
main.py	82	4	95%	46–48, 110
waypoint
main.py	48	1	98%	64
waypoint/services
nats_service.py	112	3	97%	73–75
TOTAL	4943	546	89%

Tests	Skipped	Failures	Errors	Time
896	6 💤	0 ❌	0 🔥	4m 47s ⏱️

github-actions · 2025-01-28T07:58:48Z

K8s Regression Test Coverage

File	Stmts	Miss	Cover	Missing
app
main.py	78	2	97%	119–120
app/models
wallet.py	36	4	89%	100–105
app/routes
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	139	33	76%	88–90, 95, 152–154, 159, 231, 239–241, 246, 288–293, 299–301, 362–364, 369, 406–408, 413, 449–451, 505–507
app/routes/wallet
credentials.py	80	53	34%	57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
acapy_ledger.py	61	19	69%	43–49, 79, 110–111, 124–140, 146–149, 196–197
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	166	46	72%	118–160, 201–205, 360–364, 403–408, 441–445, 463–478, 484–493, 527–528
app/services/issuer
acapy_issuer_v2.py	101	12	88%	63, 97–106, 110, 126–127, 174, 228–229, 256
app/services/onboarding
tenants.py	63	49	22%	30–103, 113–143
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	95	5	95%	100–102, 276–281
set_endorser_metadata.py	72	40	44%	32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/util
acapy_verifier_utils.py	123	5	96%	81–84, 164–168, 245
assert_public_did.py	18	12	33%	14–34
check_endorser_connection.py	10	4	60%	14–24
credentials.py	14	2	86%	13, 18
retry_method.py	36	30	17%	15–36, 68–114
save_exchange_record.py	13	1	92%	29
string.py	15	4	73%	15–16, 20, 24
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	7	50%	21–39
shared
log_config.py	53	20	62%	41–94, 103–110, 152, 161–173
shared/models
connection_record.py	24	1	96%	47
credential_exchange.py	43	7	84%	85–88, 101–104
endorsement.py	85	68	20%	36–70, 92–122, 132–179
presentation_exchange.py	40	9	78%	54–56, 62–64, 82, 87, 91
protocol.py	10	1	90%	18
trustregistry.py	63	7	89%	22, 44, 75–83
shared/services
nats_jetstream.py	36	4	89%	56, 60, 64, 68
shared/util
api_router.py	14	1	93%	17
mock_agent_controller.py	55	6	89%	23, 74–78
trustregistry
main.py	82	4	95%	46–48, 110
waypoint
main.py	48	1	98%	64
waypoint/services
nats_service.py	112	3	97%	73–75
TOTAL	4943	596	88%

Tests	Skipped	Failures	Errors	Time
896	48 💤	0 ❌	0 🔥	6m 29s ⏱️

sonarqubecloud · 2025-01-28T08:01:51Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ff137

Thanks for making the deps alphabetical too, my OCD is happy 😄

Does this mean we can bump back to 3.13, or is it still a blocker for what version can be injected?

github-actions · 2025-01-28T08:21:49Z

K8s Test Coverage

File	Stmts	Miss	Cover	Missing
app
main.py	78	2	97%	119–120
app/models
wallet.py	36	4	89%	100–105
app/routes
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	139	33	76%	88–90, 95, 152–154, 159, 231, 239–241, 246, 288–293, 299–301, 362–364, 369, 406–408, 413, 449–451, 505–507
app/routes/wallet
credentials.py	80	53	34%	57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
acapy_ledger.py	61	12	80%	110–111, 124–140, 196–197
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	166	35	79%	118–160, 201–205, 360–364, 403–408, 441–445, 473–478, 527–528
app/services/issuer
acapy_issuer_v2.py	101	12	88%	63, 97–106, 110, 126–127, 174, 228–229, 256
app/services/onboarding
tenants.py	63	49	22%	30–103, 113–143
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	95	5	95%	100–102, 276–281
set_endorser_metadata.py	72	40	44%	32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/util
acapy_verifier_utils.py	123	5	96%	81–84, 164–168, 245
assert_public_did.py	18	8	56%	17–33
credentials.py	14	2	86%	13, 18
retry_method.py	36	15	58%	20–35, 76–77, 91–103
save_exchange_record.py	13	1	92%	29
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	2	86%	34–35
shared
log_config.py	53	20	62%	41–94, 103–110, 152, 161–173
shared/models
connection_record.py	24	1	96%	47
credential_exchange.py	43	7	84%	85–88, 101–104
endorsement.py	85	68	20%	36–70, 92–122, 132–179
presentation_exchange.py	40	9	78%	54–56, 62–64, 82, 87, 91
protocol.py	10	1	90%	18
trustregistry.py	63	7	89%	22, 44, 75–83
shared/services
nats_jetstream.py	36	4	89%	56, 60, 64, 68
shared/util
api_router.py	14	1	93%	17
mock_agent_controller.py	55	6	89%	23, 74–78
trustregistry
main.py	82	4	95%	46–48, 110
waypoint
main.py	48	1	98%	64
waypoint/services
nats_service.py	112	3	97%	73–75
TOTAL	4943	546	89%

Tests	Skipped	Failures	Errors	Time
896	6 💤	0 ❌	0 🔥	4m 42s ⏱️

github-actions · 2025-01-28T08:21:50Z

K8s Regression Test Coverage

File	Stmts	Miss	Cover	Missing
app
main.py	78	2	97%	119–120
app/models
wallet.py	36	4	89%	100–105
app/routes
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	139	33	76%	88–90, 95, 152–154, 159, 231, 239–241, 246, 288–293, 299–301, 362–364, 369, 406–408, 413, 449–451, 505–507
app/routes/wallet
credentials.py	80	53	34%	57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
acapy_ledger.py	61	19	69%	43–49, 79, 110–111, 124–140, 146–149, 196–197
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	166	46	72%	118–160, 201–205, 360–364, 403–408, 441–445, 463–478, 484–493, 527–528
app/services/issuer
acapy_issuer_v2.py	101	12	88%	63, 97–106, 110, 126–127, 174, 228–229, 256
app/services/onboarding
tenants.py	63	49	22%	30–103, 113–143
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	95	5	95%	100–102, 276–281
set_endorser_metadata.py	72	40	44%	32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/util
acapy_verifier_utils.py	123	5	96%	81–84, 164–168, 245
assert_public_did.py	18	12	33%	14–34
check_endorser_connection.py	10	4	60%	14–24
credentials.py	14	2	86%	13, 18
retry_method.py	36	30	17%	15–36, 68–114
save_exchange_record.py	13	1	92%	29
string.py	15	4	73%	15–16, 20, 24
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	7	50%	21–39
shared
log_config.py	53	20	62%	41–94, 103–110, 152, 161–173
shared/models
connection_record.py	24	1	96%	47
credential_exchange.py	43	7	84%	85–88, 101–104
endorsement.py	85	68	20%	36–70, 92–122, 132–179
presentation_exchange.py	40	9	78%	54–56, 62–64, 82, 87, 91
protocol.py	10	1	90%	18
trustregistry.py	63	7	89%	22, 44, 75–83
shared/services
nats_jetstream.py	36	4	89%	56, 60, 64, 68
shared/util
api_router.py	14	1	93%	17
mock_agent_controller.py	55	6	89%	23, 74–78
trustregistry
main.py	82	4	95%	46–48, 110
waypoint
main.py	48	1	98%	64
waypoint/services
nats_service.py	112	3	97%	73–75
TOTAL	4943	596	88%

Tests	Skipped	Failures	Errors	Time
896	48 💤	0 ❌	0 🔥	6m 26s ⏱️

rblaine95 · 2025-01-28T08:33:38Z

Does this mean we can bump back to 3.13, or is it still a blocker for what version can be injected?

Unfortunately no, it doesn't seem the auto-instrumentation currently supports Python 3.13 😞
That's where the "unsupported runtime detected" warning/error comes from

rblaine95 added the dependencies Pull requests that update a dependency file label Jan 28, 2025

rblaine95 self-assigned this Jan 28, 2025

rblaine95 temporarily deployed to dev January 28, 2025 07:17 — with GitHub Actions Inactive

rblaine95 had a problem deploying to dev January 28, 2025 07:21 — with GitHub Actions Error

➖ Remove DDTrace

313ebfd

* We might not need to install it as we're using Auto Instrumentation to inject it in K8s

rblaine95 force-pushed the remove-ddtrace branch from 9464356 to 313ebfd Compare January 28, 2025 07:23

rblaine95 temporarily deployed to dev January 28, 2025 07:30 — with GitHub Actions Inactive

rblaine95 temporarily deployed to dev January 28, 2025 07:34 — with GitHub Actions Inactive

rblaine95 had a problem deploying to dev January 28, 2025 07:34 — with GitHub Actions Failure

rblaine95 temporarily deployed to dev January 28, 2025 07:49 — with GitHub Actions Inactive

rblaine95 had a problem deploying to dev January 28, 2025 07:50 — with GitHub Actions Failure

rblaine95 temporarily deployed to dev January 28, 2025 07:50 — with GitHub Actions Inactive

rblaine95 force-pushed the remove-ddtrace branch from 93dd3f2 to 313ebfd Compare January 28, 2025 07:58

rblaine95 temporarily deployed to dev January 28, 2025 08:00 — with GitHub Actions Inactive

🎨

7110474

rblaine95 requested review from ff137, cl0ete and wdbasson January 28, 2025 08:01

rblaine95 temporarily deployed to dev January 28, 2025 08:08 — with GitHub Actions Inactive

rblaine95 had a problem deploying to dev January 28, 2025 08:12 — with GitHub Actions Failure

rblaine95 temporarily deployed to dev January 28, 2025 08:12 — with GitHub Actions Inactive

ff137 approved these changes Jan 28, 2025

View reviewed changes

rblaine95 merged commit ae4d44e into master Jan 28, 2025
50 of 51 checks passed

rblaine95 deleted the remove-ddtrace branch January 28, 2025 08:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

➖ Remove DDTrace #1299

➖ Remove DDTrace #1299

rblaine95 commented Jan 28, 2025 •

edited

Loading

github-actions bot commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

sonarqubecloud bot commented Jan 28, 2025

ff137 left a comment

github-actions bot commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

rblaine95 commented Jan 28, 2025

➖ Remove DDTrace #1299

➖ Remove DDTrace #1299

Conversation

rblaine95 commented Jan 28, 2025 • edited Loading

github-actions bot commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

sonarqubecloud bot commented Jan 28, 2025

Quality Gate passed

ff137 left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

rblaine95 commented Jan 28, 2025

rblaine95 commented Jan 28, 2025 •

edited

Loading