-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Support using podman & improve tilt env reuse #1269
Conversation
🔧 to support both docker and podman (in docker compatibility mode): * switched to using tilt's `custm_build` instead of `docker_build` with `skips_local_docker=True` and pushing to local repository * introiduced ` DOCKER_HOST = "unix:///var/run/docker.sock"` env var pointing at default docker socket location 🔧 also add support for mise test task to run e2e tests and provide parameters to the test tasks, e.g: * `mise run tests -- -n 4` * `mise run tests:e2e -- -n 14`
* make the docker cache and registry container names configurable via env * fix destroy and destroy all mise scripts to handle docker cache and registry correctly and reuse running/existing to allow sharing of these when working with multiple projects
K8s Regression Test Coverage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Just need to get the workflows passing -- docker/login-action is failing in tests
https://github.com/didx-xyz/aries-cloudapi-python/actions/runs/12862232674/job/35856858278?pr=1269
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulled branch and ran tests & regression tests locally, all passed
b09d0d0
to
b801ebf
Compare
K8s Test Coverage
|
K8s Regression Test Coverage
|
K8s Test Coverage
|
K8s Regression Test Coverage
|
c61d689
to
2f6e6d5
Compare
Co-authored-by: Robbie Blaine <4052340+rblaine95@users.noreply.github.com>
K8s Test Coverage
|
K8s Regression Test Coverage
|
K8s Test Coverage
|
K8s Regression Test Coverage
|
✨ Support tilt running in podman (with docker compatibility mode):
custm_build
instead ofdocker_build
withskips_local_docker=True
and pushing to local repositoryDOCKER_HOST = "unix:///var/run/docker.sock"
env var pointing at default docker socket location🔧 Adds support for mise test task to run e2e tests and provide parameters to the test tasks, e.g:
mise run tests -- -n 4
mise run tests:e2e -- -n 4
🔧 mise kind, registry and cache tasks fixes:
🔧 adds mise tasks to format source code
mise run fmt
misse run fmt:check