-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup keyboard code #352
Conversation
Let me know when this is ready to test! |
20b7054
to
ccbaa02
Compare
Should be ready to test now. I can already see a problem with
|
In my limited testing this does fix #350 Is this PR meant to address the difference in speed between DNS text output versus dragonfly? |
Yes. It looks like that problem is caused by incorrect pauses in the |
We are all human! At least I hope :) Let me know if you can hear a high-pitched squeal from one of my fans going bad as you read this text. |
Haha :) Well, I can confirm that the behaviour doesn't occur for me using the hardware or Unicode events. It is the same speed as DNS if I set pause_default to 0. Incidentally, I plan to remove the settings.cfg file in the future; the settings are either defunct or better handled by setting class/instance members instead. |
Summary: - Change the Key and Text action classes to calculate keyboard events at execution time instead of initialization time. - Fix numerous code style issues. - Remove doc build conditionals from keyboard/__init__.py.
This change fixes a bug where the PAUSE_DEFAULT setting in the Windows-only settings.cfg file is not used properly by Text actions.
aaff1ba
to
4ebd104
Compare
This PR cleans up the keyboard code a little and fixes some bugs.
Summary:
events at execution time instead of initialization time.
This restores the list of extended keys removed from sendinput.py in PR 343. If the specified virtual-key is in this list, e.g. the insert key, then the KEYEVENTF_EXTENDEDKEY flag is used.
This change fixes a bug where the PAUSE_DEFAULT setting in the Windows-only settings.cfg file is not used properly by Text actions.
These should be removed from other files too. I plan to do that as part of a more general clean up of the platform code.