Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix body of patch operation in put cart entry #33

Merged
merged 1 commit into from
Apr 14, 2019

Conversation

fgmadeira
Copy link

Description

Add only quantity to the body of the PATCH operation.

Motivation and Context

Hybris was replying in error on put entry operation since we were sending the full entry on the patch.
This should fix the call to the cart/entries PATCH endpoint.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation improvement/changes

Checklist:

Go over all the following points, and put an x in all the boxes that apply.
If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code passes the code style as defined by TSLint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • I ran all tests locally and they pass.
  • All unit tests pass on CircleCi.

Copy link
Author

@fgmadeira fgmadeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still unclear to me if .tsbuildinfo files are to be commited or not, so i maintained them

@fgmadeira fgmadeira merged commit d07614e into diconium:master Apr 14, 2019
@fgmadeira fgmadeira deleted the feature/fix-put-cart-entry branch April 24, 2019 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant