Skip to content

Fix TradeRepublic file detection#205

Merged
dickwolff merged 5 commits into
mainfrom
feat/Fix-Traderepublic-File-Detection
May 6, 2025
Merged

Fix TradeRepublic file detection#205
dickwolff merged 5 commits into
mainfrom
feat/Fix-Traderepublic-File-Detection

Conversation

@dickwolff

@dickwolff dickwolff commented May 2, 2025

Copy link
Copy Markdown
Owner

Fixes

  • 🐛 TradeRepublic: Files in the English language are now also found when running in Docker.

Checklist

  • Added relevant changes to README (if applicable)
  • Added relevant test(s)
  • Updated GitVersion file and corresponding version in package.json

Related issue (if applicable)

Fixes #204

@coderabbitai

coderabbitai Bot commented May 2, 2025

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

This change updates the GitVersion.yml configuration to set the next-version to 0.29.4. In the src/watcher.ts file, a new CSV header pattern for the "tradeRepublic" converter is added to the headers map, matching the format Date;Type;Value;Note;ISIN;Shares;Fees;Taxes. Additionally, in the .github/workflows/docker.yml file, workflow triggers are expanded to include changes in .github/, and a debug echo statement is added to the "Automatically increase GitVersion" step to output the ALREADY_UPDATED variable.

Assessment against linked issues

Objective Addressed Explanation
Correctly detect TradeRepublic CSV exports with header Date;Type;Value;Note;ISIN;Shares;Fees;Taxes and avoid misclassification as 'Revolut' (#204)
Prevent runtime errors due to incorrect converter assignment for TradeRepublic exports (#204)

Possibly related PRs


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6ba26e7 and 47c6429.

📒 Files selected for processing (3)
  • .github/workflows/docker.yml (2 hunks)
  • GitVersion.yml (1 hunks)
  • src/watcher.ts (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dickwolff dickwolff force-pushed the feat/Fix-Traderepublic-File-Detection branch from 6ba26e7 to f265387 Compare May 2, 2025 13:49
@github-actions

github-actions Bot commented May 6, 2025

Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Complexity Health
src 100% 100% 0
src.converters 97% 90% 0
src.helpers 100% 100% 0
Summary 98% (1758 / 1801) 91% (929 / 1021) 0

@dickwolff dickwolff merged commit bdbf4c8 into main May 6, 2025
@dickwolff dickwolff deleted the feat/Fix-Traderepublic-File-Detection branch May 6, 2025 13:30
@coderabbitai coderabbitai Bot mentioned this pull request Feb 6, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TradeRepublic with Docker image]: Detected as "Revolut" > Cannot read properties of undefined

1 participant