-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix github workflow #257
Fix github workflow #257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good but please figure out why the tests workflow is skipped. The PR goes into develop, so it should be executed, right?
The test only runs when the commit has been pushed to develop or on a pull request on main. Otherwise it's skipped. I made it that way, because the test takes about 17 minutes. (can be seen in the job run of this commit: 6dbe6e8) |
I would rather like to see it run before we merge. Tests from previous commits on the PR should be canceled. I've sent you a PM with an example. |
No description provided.