Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github workflow #257

Merged
merged 10 commits into from
Jul 26, 2024
Merged

Fix github workflow #257

merged 10 commits into from
Jul 26, 2024

Conversation

nck-mlcnv
Copy link
Contributor

No description provided.

@nck-mlcnv nck-mlcnv marked this pull request as ready for review July 25, 2024 11:39
@nck-mlcnv nck-mlcnv requested a review from bigerl July 25, 2024 11:39
@nck-mlcnv nck-mlcnv changed the title Update github workflow Fix github workflow Jul 25, 2024
Copy link
Member

@bigerl bigerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good but please figure out why the tests workflow is skipped. The PR goes into develop, so it should be executed, right?

@nck-mlcnv
Copy link
Contributor Author

nck-mlcnv commented Jul 26, 2024

The test only runs when the commit has been pushed to develop or on a pull request on main. Otherwise it's skipped. I made it that way, because the test takes about 17 minutes. (can be seen in the job run of this commit: 6dbe6e8)

@bigerl
Copy link
Member

bigerl commented Jul 26, 2024

I would rather like to see it run before we merge. Tests from previous commits on the PR should be canceled. I've sent you a PM with an example.

@nck-mlcnv nck-mlcnv merged commit f85fe77 into develop Jul 26, 2024
3 checks passed
@nck-mlcnv nck-mlcnv deleted the fix/workflow branch July 26, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants