Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ResponseBodyProcessor timeout #250

Merged
merged 5 commits into from
Jun 13, 2024
Merged

Add ResponseBodyProcessor timeout #250

merged 5 commits into from
Jun 13, 2024

Conversation

nck-mlcnv
Copy link
Contributor

@nck-mlcnv nck-mlcnv commented May 29, 2024 •
edited
Loading

Adds a timeout option for the ResponseBodyProcessors. TODO:

  • update documentation (after the new one has been merged)

@nck-mlcnv nck-mlcnv self-assigned this May 29, 2024
@bigerl bigerl marked this pull request as ready for review June 6, 2024 09:06
@bigerl bigerl self-requested a review June 6, 2024 09:06
bigerl
bigerl approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@bigerl bigerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the PR. The changes look good and concise. After documentation was added this is ready to be merged.

@nck-mlcnv nck-mlcnv requested a review from bigerl June 13, 2024 12:49
@nck-mlcnv @bigerl
Update docs/configuration/response_body_processor.md
6fa4da0 
Co-authored-by: Alexander Bigerl <bigerl@mail.upb.de>
bigerl
bigerl approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@bigerl bigerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. 👍🏻 Please squash-merge into develop.

@nck-mlcnv nck-mlcnv merged commit 74d004a into develop Jun 13, 2024
2 checks passed
@nck-mlcnv nck-mlcnv deleted the feature/rbc-timeout branch June 13, 2024 13:05
@nck-mlcnv nck-mlcnv linked an issue Jul 24, 2024 that may be closed by this pull request
Add Timeout configuration for ResponseBodyProcessors #231
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigerl bigerl bigerl approved these changes

Assignees

@nck-mlcnv nck-mlcnv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Timeout configuration for ResponseBodyProcessors
2 participants
@nck-mlcnv @bigerl