Skip to content

wip - Add support for generating custom Remove methods for repeating …#5

Merged
dib0 merged 2 commits intodib0:masterfrom
nkm8:removeItem
Jan 5, 2021
Merged

wip - Add support for generating custom Remove methods for repeating …#5
dib0 merged 2 commits intodib0:masterfrom
nkm8:removeItem

Conversation

@nkm8
Copy link
Contributor

@nkm8 nkm8 commented Mar 17, 2017

…fields

These changes are dependent on nHapiNET/nHapi#75 and cannot be merged until the nHapi PR is merged and a new version is available in NuGet. After that happens, I can update this PR to bump the nHapi version and remove the local file reference to nHapi.Base.dll.

Currently, I only updated the reference in the v23 project to ensure the tests complete successfully. If you want to build/test locally, you will need to temporarily unload the other projects.

@dib0
Copy link
Owner

dib0 commented Mar 18, 2017

Thanks! Let's wait on #75 in nHapi before integrating this.

@nkm8
Copy link
Contributor Author

nkm8 commented Nov 2, 2020

Looks like there is finally some motion on nHapiNET/nHapi#75
I pulled from master and resolved the merge conflicts - I don't use nHapi anymore, so I can't easily build/test this.

@dib0 dib0 merged commit 9c72155 into dib0:master Jan 5, 2021
@milkshakeuk
Copy link
Collaborator

@dib0 Hi, the changes to nHapi are in master but not in a release version yet, I'm hoping to create a new Preview Release soon with @nkm8 changes in.

In Theory you could create a preview version of NHapiTools that generates source code from the preview release of nHapi once it's been created/released.

@milkshakeuk
Copy link
Collaborator

@dib0 the changes are in v3.0.0-preview.2 and of course v3.0.0-preview3, I'll let you know when v3 final is releeased.

@milkshakeuk
Copy link
Collaborator

@dib0 nHapi v3 has been released and #21 should enable this PR to generate the extra extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants