Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use full path for temporary filename #1871

Merged
merged 2 commits into from
Jun 15, 2018
Merged

use full path for temporary filename #1871

merged 2 commits into from
Jun 15, 2018

Conversation

olgabot
Copy link
Contributor

@olgabot olgabot commented Jun 15, 2018

In trim-low-abund.py, use the full path of the input filename rather than only the basename, in case of identical basenames which causes errors.

  • Is any new functionality in tested? (This can be checked with
    make clean diff-cover or the CodeCov report that is automatically
    generated following a successful CI build.)
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Have any changes to the command-line interface been explicitly described?
    Only backwards-compatible additions are allowed without a major version
    increment. Changing file formats also requires a major version number
    increment.
  • Have any substantial changes been documented in CHANGELOG.md? See
    keepachangelog for more details.
  • Do the changes respect streaming I/O? (Are they tested for streaming I/O?)

@codecov-io
Copy link

codecov-io commented Jun 15, 2018

Codecov Report

Merging #1871 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1871   +/-   ##
======================================
  Coverage    0.07%   0.07%           
======================================
  Files          67      67           
  Lines        6685    6685           
  Branches     2487    2487           
======================================
  Hits            5       5           
  Misses       6680    6680
Impacted Files Coverage Δ
scripts/trim-low-abund.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c89307...8279f31. Read the comment docs.

Copy link
Member

@standage standage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very concise solution to an annoying problem. Thanks!

@standage standage merged commit fe0ce11 into dib-lab:master Jun 15, 2018
@standage
Copy link
Member

Closes #1870.

@standage
Copy link
Member

Thanks for you contribution @olgabot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants