-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] "consume_masked" mode for consume_seqfile_with_mask #1867
Conversation
This comment has been minimized.
This comment has been minimized.
Ready for review and merge! @betatim @camillescott @ctb @luizirber |
Hi @standage the code looks good but I am not sure why you chose |
I explained this briefly in the first paragraph of the PR, but I am open to using different terminology for the variable names if it communicates intent more clearly. The old behavior of Let me know what you think regarding terminology. |
I finally remembered to search for "set complement" and that is the right definition :). Glad I found it! What about |
Roger that. I like it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thank you |
In branch
feature/mask-comp
I implemented a newcomplement
consume_masked
option for theconsume_seqfile_with_mask
method. By default, the function will not count any k-mers present in the mask, but withcomplement=True
consume_masked=True
the function will count only the k-mers present in the mask/filter.In that branch I also putzed around with some Python code (utils and scripts) to get that functionality working in
abundance-dist-single.py
.This PR splits the C++/Cython changes from the Python changes, the latter of which aren't ready for review yet. The C++/Cython functionality is blocking my progress on a feature in kevlar, whereas I don't have a pressing need to bake this in to khmer scripts at the moment.
make clean diff-cover
or the CodeCov report that is automaticallygenerated following a successful CI build.)
changes were made?