Skip to content

Conversation

ctSkennerton
Copy link
Contributor

I recently tried to install khmer from source and kept getting errors due to this makefile. below is the relevant line after running python setup.py.install

bash -c cd third-party/cqf && make
g++ -std=c++11 -fPIC -Wall   -Ofast  -m64 -I. -Wno-unused-result -Wno-strict-aliasing -Wno-unused-function /opt/intel/composerxe-2011.4.191/ipp/include:/opt/intel/composerxe-2011.4.191/mkl/include:/opt/intel/composerxe-2011.4.191/ipp/include:/opt/intel/composerxe-2011.4.191/mkl/include gqf.c -c -o gqf.o
g++: error: /opt/intel/composerxe-2011.4.191/ipp/include:/opt/intel/composerxe-2011.4.191/mkl/include:/opt/intel/composerxe-2011.4.191/ipp/include:/opt/intel/composerxe-2011.4.191/mkl/include: No such file or directory

The problem seems to be that the $(INCLUDE) variable gets expanded out to a list of paths but does not include the -I argument. I'm guessing that on other systems $(INCLUDE) is expanded to an empty variable and thus doesn't produce an error. This simple change adds in the -I.


Message from the khmer maintainers:

Please provide a description of the pull request above, including a
reasonable level of detail and references to any relevant threads. After
creating the pull request, complete and mark the checklist below. If any item
is not applicable, feel free to remove it or mark it as complete. If you are
unsure about any item, feel free to ask about it before or during code
review.

When you are ready for the pull request to be reviewed, please post a comment
with a message such as "Ready for review!"

  • Is any new functionality in tested? (This can be checked with
    make clean diff-cover or the CodeCov report that is automatically
    generated following a successful CI build.)
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Have any changes to the command-line interface been explicitly described?
    Only backwards-compatible additions are allowed without a major version
    increment. Changing file formats also requires a major version number
    increment.
  • Have any substantial changes been documented in CHANGELOG.md? See
    keepachangelog for more details.
  • Do the changes respect streaming I/O? (Are they tested for streaming I/O?)

I recently tried to install khmer from source and kept getting errors due to this makefile. below is the relevant line after running `python setup.py.install`

```
bash -c cd third-party/cqf && make
g++ -std=c++11 -fPIC -Wall   -Ofast  -m64 -I. -Wno-unused-result -Wno-strict-aliasing -Wno-unused-function /opt/intel/composerxe-2011.4.191/ipp/include:/opt/intel/composerxe-2011.4.191/mkl/include:/opt/intel/composerxe-2011.4.191/ipp/include:/opt/intel/composerxe-2011.4.191/mkl/include gqf.c -c -o gqf.o
g++: error: /opt/intel/composerxe-2011.4.191/ipp/include:/opt/intel/composerxe-2011.4.191/mkl/include:/opt/intel/composerxe-2011.4.191/ipp/include:/opt/intel/composerxe-2011.4.191/mkl/include: No such file or directory
```

The problem seems to be that the `$(INCLUDE)` variable gets expanded out to a list of paths but does not include the `-I` argument. I'm guessing that on other systems `$(INCLUDE)` is expanded to an empty variable and thus doesn't produce an error. This simple change adds in the `-I`.
@standage
Copy link
Member

Thanks @ctSkennerton. The CI failures are unrelated to your code (this always happens when we receive contributions from a fork instead of the main repository; I will document in a separate thread, and it shouldn't hold up merging this PR).

Fill out the checklist and let us know when you're ready for a review!

@standage
Copy link
Member

Fill out the checklist and let us know when you're ready for a review!

In this case, the changes are so small that most of the checklist can be ignored :-)

@ctSkennerton
Copy link
Contributor Author

Thanks @standage I was wondering about why it failed. It's ready for review.

@standage standage mentioned this pull request May 18, 2018
5 tasks
@standage
Copy link
Member

Hi @ctSkennerton!

I've solved our TravisCI/Docker bug in #1864. As soon as someone approves and merges that PR, I'll integrate those changes into this PR and merge.

@codecov-io
Copy link

codecov-io commented May 18, 2018

Codecov Report

Merging #1863 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1863   +/-   ##
======================================
  Coverage    0.07%   0.07%           
======================================
  Files          67      67           
  Lines        6679    6679           
  Branches     2485    2485           
======================================
  Hits            5       5           
  Misses       6674    6674

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b38e1d...56a708c. Read the comment docs.

Copy link
Member

@standage standage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@standage standage merged commit 599cc34 into dib-lab:master May 18, 2018
@standage
Copy link
Member

Thanks @ctSkennerton!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants