-
Notifications
You must be signed in to change notification settings - Fork 296
Update makefile #1863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update makefile #1863
Conversation
I recently tried to install khmer from source and kept getting errors due to this makefile. below is the relevant line after running `python setup.py.install` ``` bash -c cd third-party/cqf && make g++ -std=c++11 -fPIC -Wall -Ofast -m64 -I. -Wno-unused-result -Wno-strict-aliasing -Wno-unused-function /opt/intel/composerxe-2011.4.191/ipp/include:/opt/intel/composerxe-2011.4.191/mkl/include:/opt/intel/composerxe-2011.4.191/ipp/include:/opt/intel/composerxe-2011.4.191/mkl/include gqf.c -c -o gqf.o g++: error: /opt/intel/composerxe-2011.4.191/ipp/include:/opt/intel/composerxe-2011.4.191/mkl/include:/opt/intel/composerxe-2011.4.191/ipp/include:/opt/intel/composerxe-2011.4.191/mkl/include: No such file or directory ``` The problem seems to be that the `$(INCLUDE)` variable gets expanded out to a list of paths but does not include the `-I` argument. I'm guessing that on other systems `$(INCLUDE)` is expanded to an empty variable and thus doesn't produce an error. This simple change adds in the `-I`.
Thanks @ctSkennerton. The CI failures are unrelated to your code (this always happens when we receive contributions from a fork instead of the main repository; I will document in a separate thread, and it shouldn't hold up merging this PR). Fill out the checklist and let us know when you're ready for a review! |
In this case, the changes are so small that most of the checklist can be ignored :-) |
Thanks @standage I was wondering about why it failed. It's ready for review. |
Hi @ctSkennerton! I've solved our TravisCI/Docker bug in #1864. As soon as someone approves and merges that PR, I'll integrate those changes into this PR and merge. |
Codecov Report
@@ Coverage Diff @@
## master #1863 +/- ##
======================================
Coverage 0.07% 0.07%
======================================
Files 67 67
Lines 6679 6679
Branches 2485 2485
======================================
Hits 5 5
Misses 6674 6674 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Thanks @ctSkennerton! |
I recently tried to install khmer from source and kept getting errors due to this makefile. below is the relevant line after running
python setup.py.install
The problem seems to be that the
$(INCLUDE)
variable gets expanded out to a list of paths but does not include the-I
argument. I'm guessing that on other systems$(INCLUDE)
is expanded to an empty variable and thus doesn't produce an error. This simple change adds in the-I
.make clean diff-cover
or the CodeCov report that is automaticallygenerated following a successful CI build.)
changes were made?
Only backwards-compatible additions are allowed without a major version
increment. Changing file formats also requires a major version number
increment.
CHANGELOG.md
? Seekeepachangelog for more details.