remember items bought from shops #3176
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qndel
force-pushed
the
fix_shop_restock
branch
from
508f7b0
to
81c0320
Compare
|
Nice, I guess having this fixed before release is a good idea :D |
qndel
force-pushed
the
fix_shop_restock
branch
from
81c0320
to
5cba6b8
Compare
glebm
reviewed
Oct 20, 2021
|
Isn't this a bug? |
qndel
force-pushed
the
fix_shop_restock
branch
from
5cba6b8
to
f3c92d7
Compare
glebm
reviewed
Oct 20, 2021
obligaron
reviewed
Oct 20, 2021
| void SaveBoughtItems() | ||
| { | ||
| size_t boughtItemsDataSize = sizeof(uint32_t) * (4 + boughtSmithItems.size() + boughtWitchItems.size() + boughtHealerItems.size()); | ||
| SaveHelper file("boughtitems", boughtItemsDataSize); |
There was a problem hiding this comment.
We add new content to the save with this or?
If yes should we add at least uint32 version-number (at the moment hard coded 1).
If we want to change the format later and also need a update?
There was a problem hiding this comment.
meh
I don't see how microsomal epoxide hydrolase is related? 🤔
There was a problem hiding this comment.
The other item files start with uint8_t, 0 for diablo and 1 for hellfire, would be good to follow that pattern :)
|
I'm this is starting to become a bit unintuitive and we may as well store the shop items the same way as is already done for the smith prim items to keep things simple. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3172