Avoid segfaults when using randomly generated array indexes in items.cpp #2762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephphatha
commented
Aug 31, 2021
| @@ -1445,7 +1459,7 @@ int RndUItem(MonsterStruct *monster) | |||
| } | |||
| } | |||
|
|
|||
| return ril[GenerateRnd(ri)]; | |||
| return ril[GenerateNonNegativeRnd(ri)]; | |||
There was a problem hiding this comment.
This seemed like the safest way to handle this, I don't think reading invalid memory was actually useful for any generated items but it may break compatibility. That said, with the way it was working previously any unrelated code change potentially could've broken compatibility, no way to know without tests for the exceptional case.
ephphatha
commented
Aug 31, 2021
|
Lets fix all these signed/unsigned comparisons 🙃 |
ephphatha
force-pushed
the
random-oob
branch
from
ec0495f
to
81c14e7
Compare
ephphatha
force-pushed
the
random-oob
branch
3 times, most recently
from
1cb4718
to
e462adc
Compare
Force template type to satisfy 3ds/android builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first couple of commits set up helpers for future checks. Items.cpp was one of the easier wins, drlg1.cpp is probably the worst offender so I'm trying to avoid that one as long as possible 😂