Search Spell Improvements

[vladtepesch]

Some Improvement of Devilution reduces the usefullness of the Search spell:

• objects visibility due to increased screen size vs the automap range of the spell
• Diablo 2 style item display by CTRL-key vs item highlighting

I tried to add some features to make the spell more attractive to be used:

Also unopened container objects are highlighted
Also unopened container items are shown own map as darker blue tile marker.
The automap display range is increased by one every 3 spell levels.

[qndel]

I wouldn't touch search at all - for people that want to shit on it there's alt highlighting, for people that don't, there's 100% vanilla search, I'm fine with it being that way

[vladtepesch]

I wouldn't touch search at all - for people that want to shit on it there's alt highlighting, for people that don't, there's 100% vanilla search, I'm fine with it being that way

then maybe an additional game option?
The whole point of the improvement is that currently with the alternative highlighting there is no need for the current implementation of the spell. To correct the balancing I added some additional usefulnes.

Regarding "vanilla": the spell expierenced significant changes during some hellfire patches at the time (at beginning there was no map highlight) - so what exactly does "vanilla" mean? The whole Search spell is a convinient feature.

I would be with you if we would talk about changing fundamental spells that influences the game play.

[vladtepesch]

for some reason the appveyour ci check crashes with internal server error. Seems to be unrelated to the the commit

[AJenbo]

Since this by definition is game changing it is pushing the bounds of what DevilutionX aim to do. But I do agree with the primes layid out in the PR description. As we are currently trying to narrow things down for the 1.3.0 release I'm going to push the final decision of what to do here until the 1.4.0 cycle, But if nothing else I think this makes for a very interesting mod feature.

[vladtepesch]

I added the gameoption (default off) so it should be fine, isn't it?
I mean the alt-Highlighting is definitevly more changing and does not even has an option

[vladtepesch]

if not then maybe close the PR, so that you does not got notified everytime i push to my branch after a rebase

[AJenbo]

I mean the alt-Highlighting ... does not even has an option

It still needs a bit of tweaking in this regard.

if not then maybe close the PR, so that you does not got notified

Thats not a problem for me, and I think it's good if more people notice this and gets to weigh in on it

[julealgon]

I like the idea of having the automap range modifiable. Would be nice to have this as a mechanic even if it is not surfaced in the game right now, for modding purposes.

Actually, I wonder if it wouldn't make even more sense to have automap range be based on light radius.