Skip to content

[hellfire] PlaceUniqueMonst bin exact #1896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AJenbo merged 1 commit into from
Jan 1, 2020
Merged

[hellfire] PlaceUniqueMonst bin exact #1896

AJenbo merged 1 commit into from
Jan 1, 2020

Conversation

@qndel
Copy link
Member

@qndel qndel commented Jan 1, 2020

bin exact in vanilla in hellfire
reordered the if so most of it can be reused in both vanilla and hellfire

@qndel qndel added help wanted Extra attention is needed Binary exact hellfire labels Jan 1, 2020
@AJenbo AJenbo mentioned this pull request Jan 1, 2020
Open
@AJenbo AJenbo merged commit a0a6589 into diasurgical:hellfire Jan 1, 2020
@AJenbo AJenbo deleted the PlaceUniqueMonst branch January 1, 2020 16:18
@AJenbo
Copy link
Member

AJenbo commented Jan 1, 2020

looks like this cause diff in diablo
1% change, 2536 insertions(+), 2564 deletions(-)
1% change, 2548 insertions(+), 2576 deletions(-)

@qndel
Copy link
Member Author

qndel commented Jan 1, 2020

Fixed in #1901 - seems I got the new if wrong, well, no reusing code it seems ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Binary exact hellfire help wanted Extra attention is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@qndel @AJenbo