Use top-left grid cell when syncing staff charges#8501
Use top-left grid cell when syncing staff charges#8501StephenCWills wants to merge 1 commit intodiasurgical:masterfrom
Conversation
|
LGTM This seems reasonable to me. InvGrid already treats negative entries as part of the same item in other places, so using std::abs(...) here looks like a consistency fix rather than a workaround. |
|
It's not about consistency or workaround. It needs to pass the index of the top-left grid cell to |
|
Now that I think about it, this fix only applies to the source-side of the communications. A malicious client could still force an OOB on a remote client by passing the wrong index. This fix isn't quite sufficient. |
24c0a7c to
5ba1dad
Compare
|
I added validation on the receiving end so this should be ready for review. |
This resolves #8500