Skip to content

Conversation

@yuripourre
Copy link
Collaborator

@yuripourre yuripourre commented Dec 22, 2025

This PR turns the gameplay toggle to refill mana when talking to Adria into a mod.

When I created the PR to add this feature it was a huge controversy (and of course I understand and agree with @qndel and others). Back then we didn't have the lua structure in place so now is much easier to make it as a mod.

#1136

At the same time I can learn more about how to make mods and create mods that can serve as example for other devs.

@yuripourre yuripourre marked this pull request as draft December 22, 2025 18:00
@AJenbo
Copy link
Member

AJenbo commented Dec 22, 2025

it seems odd why this PR would break the demo, the feature was not enabled and the player isn't even in town.

@yuripourre yuripourre marked this pull request as ready for review December 22, 2025 18:25
@yuripourre
Copy link
Collaborator Author

yuripourre commented Dec 22, 2025

it seems odd why this PR would break the demo, the feature was not enabled and the player isn't even in town.

I think it's because I removed the "Adria Refil Mana" from the saved configurations:

WriteByte(out, static_cast<uint8_t>(*options.Gameplay.adriaRefillsMana));

https://github.com/diasurgical/DevilutionX/pull/8371/files#diff-9180dcad034212a97d5acf1d39ec2ccc73cfeb0353b6102ef73b40a34aa2b6bfL234

@yuripourre yuripourre force-pushed the refil-mana-as-mod branch 4 times, most recently from 5c88375 to 5280673 Compare December 22, 2025 20:25
@yuripourre
Copy link
Collaborator Author

@AJenbo fixed!

@yuripourre yuripourre changed the title Refil mana as mod Adria refill mana as mod Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants