Multiple header rows #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith multiple header rows.
|
Thanks for merging 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just added implemention for multiple header rows in the table. This should also fix the Issue #29 but with two important updates:
getHeaderAndDataHeight()method now return table height (overall cells heights) but doesn't acknowledge possible page break so please use with caution.getMinimumHeight()method calculates minimal table height that needs to be drawn on the next page if page break occurs so it is used to check whether the table shall start at the next page (in case the first data row does not fit on the current page).I added also another test case
SampleTest4()in TableTest class for showing multiple header rows case.