feat: allow alerts to be undismissable [LIBS-360]

[amcgee]

Implements LIBS-360

---

Description

This implements an additional dismissible flag in the AlertBar props which optionally disables the "dismiss" X button

---

Checklist

• API docs are generated
• Tests were added
• Storybook demos were added

All points above should be relevant for feature PRs. For bugfixes, some points might not be relevant. In that case, just check them anyway to signal the work is done.

---

Screenshots

supporting text

[dhis2-bot]

🚀 Deployed on https://pr-1161--dhis2-ui.netlify.app

[cypress]

---

Test summary

556 • 10 • 0 • 0

---

Run details

Project	ui
Status	Failed
Commit	54ee56c
Started	Oct 17, 2022 4:40 PM
Ended	Oct 17, 2022 4:49 PM
Duration	08:48 💡
OS	Linux Ubuntu - 20.04
Browser	Electron 94

View run in Cypress Dashboard ➡️

---

Failures

	components/alert/src/alert-bar/features/api.feature		5
1	AlertBar API > AlertBar icon shows by default
2	AlertBar API > Custom AlertBar icon
3	AlertBar API > Standard AlertBar with a message
4	AlertBar API > The AlertBar renders with a permanent flag
5	AlertBar API > AlertBar will call the onHidden cb when hidden
	components/alert/src/alert-bar/features/hide.feature		4
1	Hiding the AlertBar > AlertBar hides automatically after the default time
2	Hiding the AlertBar > AlertBars hides automatically after a custom time
3	Hiding the AlertBar > The user clicks the "Cancel" button
4	Hiding the AlertBar > The hidden prop is toggled
	components/alert/src/alert-stack/features/render_children.feature		1
1	Shows AlertBars > AlertStack with AlertBars

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[Mohammer5]

So far we've tried to keep boolean prop names to be not a negation (:heavy_check_mark:) but also to default to "false" (:negative_squared_cross_mark:). Here is a good example.

I guess in this case it's a shame that permanent already has a different meaning, which does not reflect the actual meaning of that word. Maybe something like irremovable, undismissible or disableDismission?

[stale]

Hi!

Due to a lack of activity on this issue over time (180 days) it seems to be stale. If still relevant, please provide information that moves it forward, e.g. additional information, a pull request with suggested changes, or a reason to keep it open.

Any activity will keep it open, otherwise it will be closed automatically in 30 days. Thanks! 🤖