-
Notifications
You must be signed in to change notification settings - Fork 8
docs(2021-04-13): frontend initiatives meeting minutes #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f5671ba
docs(2021-04-13): frontend initiatives meeting minutes
varl 37fe5fd
chore: update decisions/2021/04/13-fe-initiatives.md
varl d790cbd
refactor: apply suggestions from code review
varl 753dcd4
refactor: update decisions/2021/04/13-fe-initiatives.md
varl d8a140f
refactor: update after comments in pr
varl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,103 @@ | ||
When: April 13, 2021 @ 15:00 CET | ||
Where: Online | ||
Attending: Austin, Viktor, Bjørn, Christos, Debora, Edoardo, Ismay, | ||
Jan-Gerke, Joakim, Joe, Kai, Martin, Simona, Hendrik, Médi-Rémi, | ||
Jennifer, Jan Henrik, Birk | ||
|
||
# Agenda | ||
|
||
## Introductions! | ||
|
||
- Welcome Simona! | ||
|
||
## Decisions | ||
|
||
### Standardize application file layout #248 | ||
|
||
Discussion: https://github.com/dhis2/notes/discussions/257 | ||
|
||
Goal was unambiguous rules, difficult to define across all | ||
application sizes. | ||
|
||
Guidelines: | ||
|
||
1. Have similar organisation strategies between all our apps | ||
2. Organise by-function, not by-type | ||
3. Avoid ambiguity (i.e. no conceptual overlap in folder names) | ||
4. Avoid generic folder names, and attempt to chose names that | ||
immediately reveal what’s inside | ||
5. Accept that a project-structure is not a static thing you can | ||
define up-front, the structure should evolve with the app | ||
|
||
Rules: | ||
|
||
1. Routes live under `src/pages` | ||
2. Components live under `src/components` and must only contain JSX | ||
files | ||
varl marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
Conclusion is that the 5 guidelines above and the 1 rule is adopted, and will be written up | ||
varl marked this conversation as resolved.
Show resolved
Hide resolved
|
||
and documented. | ||
|
||
## Task Forces & Updates | ||
|
||
### PWA / Offline Caching | ||
|
||
Platform side is working on recording network calls, start and stopping. | ||
varl marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
Analytics side is focusing on the dashboard app and aligning with the | ||
API that the platform will provide and what should be cached, and what | ||
should not be cached. | ||
|
||
### Continuous Delivery | ||
|
||
Over the next few weeks all our core apps are going to be uploaded to | ||
the App Hub. | ||
|
||
Need to update our release toolchain to publish to the App Hub as a | ||
semantic-release plugin. | ||
|
||
### Developer Outreach | ||
|
||
Good turn out for the developer meet ups on last Friday. The developer | ||
community is growing, and fun to see interaction between the community | ||
members. | ||
|
||
Joined Android and Webapp academy for advanced topics first week of May | ||
over the course of 4 days. Currently working on the agenda. | ||
|
||
Advanced topics like i18n, testing, and security. | ||
|
||
Collaborators needed, please reach out to Debora if you would like to | ||
present. | ||
|
||
If you don't want to present, you can help by producing guides for the | ||
developers.dhis2.org site. | ||
varl marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
### PR Previews | ||
|
||
Got OK to use Netlify, ready to move ahead with this. | ||
|
||
Next step is to whitelist the PR urls, and setup the actions. | ||
|
||
### Large collections APIs | ||
|
||
Now that Platform is used for national installations with COVID | ||
vaccinations we are hitting restrictions in terms of option sets with | ||
tens of thousands of options, that are difficult to manage given | ||
restrictions in the API. | ||
varl marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
Backend is working on: | ||
|
||
- Partial update support. JSON Patch specification is being | ||
implemented. | ||
|
||
- New Gist API is worked on that will be a more performant variant that | ||
doesn't return all the nested collections. Will contain a suite of | ||
queries and selectors to help when asking for data. | ||
|
||
varl marked this conversation as resolved.
Show resolved
Hide resolved
|
||
### Others? | ||
|
||
#### cli-utils-docsite | ||
|
||
Feature in docsite to use react-docgen. | ||
varl marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.