Skip to content

feat: run automated workflow for CI tests#5

Merged
karimbahgat merged 7 commits intomainfrom
CLIM-358
Jan 21, 2026
Merged

feat: run automated workflow for CI tests#5
karimbahgat merged 7 commits intomainfrom
CLIM-358

Conversation

@karimbahgat
Copy link
Collaborator

@karimbahgat karimbahgat commented Jan 14, 2026

https://dhis2.atlassian.net/browse/CLIM-358

  • Run testing workflow on pushes and PRs to main
  • Data download tests would be slow and unnecessary to run all the time, instead run manually with pytest -v -m integration
  • Show test and release status on repo frontpage/readme
  • Don't run linting as part of workflow until we have time to fix all the formatting (so we can show the workflow status as green)

with:
python-version: "3.10"

- run: pip install -e ".[dev]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems this is a uv project, why are we using pip here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not requiring uv for dhis2eo, trying to keep it light and use builtin tooling as much as possible, and dependencies aren't so big that we need the speed of uv.

Until we make the first Github release, just install from the main Github repo:

```bash
pip install git+https://github.com/dhis2/dhis2eo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also include uv instructions?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could have a PR later that maybe adds more support and instructions for uv users

To avoid unnecessary computation and server load, tests for the `data` integrations are marked with `@pytest.mark.integration` and are skipped by default. To run them manually:

```bash
pytest -v -m integration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better done with a Makefile

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach to dhis2eo is to keep it lightweight with fewer extra installs, not everyone is used to Makefiles and would need to be installed on Windows.

@karimbahgat karimbahgat merged commit 4eaf144 into main Jan 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants