refactor: AbstractTrackerPersister should be more readable now [TECH-775]

[gnespolino]

as mentioned in #9069 the handle method looked too complex, so I tried to split it up and simplify it as much as possible.
Please besides reviewing the solution, also take some minutes to verify no major issues have been introduced.

[zubaira]

LGTM!

[lucaCambi77]

It looks good to me, however, I'd prefer not to use nested classes and extract them in a separate package with that visibility

[enricocolasante]

In my opinion the code is not more readable, it is more compact and maybe hidden in a better way in a inner class but it is difficult to follow the flow of the code and understanding what is happening

[gnespolino]

It looks good to me, however, I'd prefer not to use nested classes and extract them in a separate package with that visibility

CTX class is now in a separate file

[teleivo]

@gnespolino thank you for taking the time to dig into making this class more readable 😄

I have to side with @enricocolasante that I do not think adding the TrackedEntityAttributeValueContext class helps in readability. I do think the changes you made to the AbstractPersiter are more readable though. So the flow in general and how you reduced nesting 😁 I believe it should be possible to move the code in TrackedEntityAttributeValueContext back into the AbstractPersister as private methods. Some of the methods as I commented, can also be inlined IMHO. We would still get the benefit of less nesting/more readable code without an extra abstraction.

[teleivo]

Like we discussed on the call I leave it up to you if you go with this version or the "inline" version without the Context class 😄

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication